Repository navigation
chore: verify immutable codesplit - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent maintenance changes. No contract, ABI, dependency or CI changes.
immutablevalues could never be confirmedimmutable-substitution-matchis a source-proven result with exit 0, and the slot positions and on-chain values are saved as evidenceethersand triggered Vite's 500 kB warningmanualChunkssplitsethersandreact/react-dominto cacheable vendor chunks; no warning0x9b824CA6…A8f6860x5A5AeaE5…2B964F, matching.env.localscripts/verify-deployment.mjsnow ranks full match (3) > immutable match (2) > executable-only match (1), stops the bounded 64-compile search once the source is proven, and writes*-immutable.jsonalongside the existing evidence. All evidence files still usewxwrites, so existing results are never overwritten. The committed evidence underdocs/evidence/deployment/(block12080309) shows the repository default profile — solc 0.8.24, optimizer on, Paris — matching on the first compile: four slots at 1024 / 1076 / 9354 / 9461 all hold 600, the two 600-second immutable timeouts. The ABI still matches the repository one.vite.config.jsis the only frontend change;contracts/MilestoneFund.sol,src/abi/MilestoneFund.json,scripts/compile-contract.mjsandpackage*.jsonare untouched.Notes / Rollout
verify:deploymentremains a manual networked command, since CI only runs the format check, tests and the Pages build.README.md(lines 173/185) anddocs/deployment-verification.mdstill describe the old full-match-only exit code and the old default address. They are not updated here: docs: modify README #16 rewritesREADME.md, so the doc update is better made once that PR lands.immutableSubstitution()has no dedicated unit test yet; the read-only Sepolia run above and the committed evidence are the current proof.