Skip to content

chore: verify immutable codesplit - #17

Merged
misaka10111 merged 3 commits into
mainfrom
chore/verify-immutable-codesplit
Nov 7, 2026
Merged

misaka10111 merged 3 commits into
mainfrom
chore/verify-immutable-codesplit

Conversation

@misaka10111

@misaka10111 misaka10111 commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Two independent maintenance changes. No contract, ABI, dependency or CI changes.

Change Before After
Deployment verification Only a byte-for-byte full runtime match returned exit 0, so a deployment with non-zero immutable values could never be confirmed Recognise two-byte zero immutable placeholders substituted by constructor values; immutable-substitution-match is a source-proven result with exit 0, and the slot positions and on-chain values are saved as evidence
Production bundles The app chunk carried ethers and triggered Vite's 500 kB warning manualChunks splits ethers and react/react-dom into cacheable vendor chunks; no warning
Default verify address Previous Sepolia instance 0x9b824CA6…A8f686 Current deployment 0x5A5AeaE5…2B964F, matching .env.local

scripts/verify-deployment.mjs now ranks full match (3) > immutable match (2) > executable-only match (1), stops the bounded 64-compile search once the source is proven, and writes *-immutable.json alongside the existing evidence. All evidence files still use wx writes, so existing results are never overwritten. The committed evidence under docs/evidence/deployment/ (block 12080309) shows the repository default profile — solc 0.8.24, optimizer on, Paris — matching on the first compile: four slots at 1024 / 1076 / 9354 / 9461 all hold 600, the two 600-second immutable timeouts. The ABI still matches the repository one.

vite.config.js is the only frontend change; contracts/MilestoneFund.sol, src/abi/MilestoneFund.json, scripts/compile-contract.mjs and package*.json are untouched.

Notes / Rollout

  • No redeployment, environment variable or GitHub Pages change is needed; verify:deployment remains a manual networked command, since CI only runs the format check, tests and the Pages build.
  • README.md (lines 173/185) and docs/deployment-verification.md still describe the old full-match-only exit code and the old default address. They are not updated here: docs: modify README #16 rewrites README.md, so the doc update is better made once that PR lands.
  • immutableSubstitution() has no dedicated unit test yet; the read-only Sepolia run above and the committed evidence are the current proof.

@misaka10111 misaka10111 changed the title Chore/verify immutable codesplit chore: verify immutable codesplit Nov 7, 2026
@misaka10111
misaka10111 merged commit 4a77279 into main Nov 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant