Add ARMSX1/ARMSX2 smart cache support - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Armsx1SmartCacheStrategyandArmsx2SmartCacheStrategy, sharing one query helper, that pull recently played games from ARMSX2'sRecentGamesContentProvider(title, file URI, serial, lastPlayed). Unlike WatermelonDS, ARMSX2 doesn't precompute an RA hash, so these candidates go through the normal hash-then-lookup path.Also fixes
toAbsoluteStoragePath()to handlefile://URIs, not justcontent://. ARMSX2's provider returns plainfile://paths, and those were falling through unresolved.Upstream is merged and shipped: ARMSX2/ARMSX2#566, released in 2.6.6.8. ARMSX1 carries the same patch in ARMSX2/ARMSX1#10 (still open).
Verified end-to-end on-device before rebase: OutRun 2006 matched RA gameId 20859 and cached; a second PS2 game correctly got a real "no match" from RA's own API (unrecognized dump, not a bug).
Replaces #88, which was invalidated when #87 was squash-merged. Rebased onto the current
mainand ported to the newEmulatorenum API (isInstalled/isEnabled,packageCandidates) — package candidate lists and installed/enabled semantics are equivalent to the old per-emulator booleans.Tracked in #33.