Skip to content

refactor(routes): share the isStatusLabel guard #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joryirving merged 2 commits into from
Jul 1, 2026
Merged

refactor(routes): share the isStatusLabel guard #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a34501
refactor(routes): share the isStatusLabel guard
Jul 1, 2026
7b55625
Merge branch 'main' into refactor/shared-status-label-guard
joryirving Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/app/api/issues/move/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
import { NextResponse } from "next/server";
import { prisma } from "@/lib/prisma";
import { updateIssueLabels, removeIssueLabel, addIssueLabel } from "@/lib/github";
import { STATUS_LABELS, StatusLabel } from "@/types";
import { STATUS_LABELS, isStatusLabel } from "@/types";
import { authorizeRequest, getAuthorizedActor } from "@/lib/auth";

function isStatusLabel(label: string): label is StatusLabel {
return (STATUS_LABELS as readonly string[]).includes(label);
}

export async function POST(request: Request) {
const auth = await authorizeRequest(request);
if (!auth.authorized) {
Expand Down
6 changes: 1 addition & 5 deletions src/app/api/issues/status/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
import { NextResponse } from "next/server";
import { prisma } from "@/lib/prisma";
import { removeIssueLabel, addIssueLabel } from "@/lib/github";
import { STATUS_LABELS, StatusLabel } from "@/types";
import { STATUS_LABELS, StatusLabel, isStatusLabel } from "@/types";
import { authorizeRequest, getAuthorizedActor } from "@/lib/auth";

function isStatusLabel(label: string): label is StatusLabel {
return (STATUS_LABELS as readonly string[]).includes(label);
}

export async function POST(request: Request) {
const auth = await authorizeRequest(request);
if (!auth.authorized) {
Expand Down
5 changes: 5 additions & 0 deletions src/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ export const BOARD_COLUMNS: BoardColumn[] = [

export const STATUS_LABELS: StatusLabel[] = BOARD_COLUMNS.map((col) => col.id);
export const PRIORITY_LABELS: PriorityLabel[] = ["priority/p0", "priority/p1", "priority/p2", "priority/p3"];

/** Type guard: is `label` one of the allowed `status/*` labels? */
export function isStatusLabel(label: string): label is StatusLabel {
return (STATUS_LABELS as readonly string[]).includes(label);
}
export const PROJECT_PREFIX = "project/";
export const AGENT_PREFIX = "agent/";
export const OWNER_PREFIX = "owner/";
Expand Down