Skip to content

Adding#2

Merged
funkiirabu merged 1 commit into
mainfrom
feat/deepbook
Jan 26, 2026
Merged

Adding#2
funkiirabu merged 1 commit into
mainfrom
feat/deepbook

Conversation

@funkiirabu
Copy link
Copy Markdown
Member

@funkiirabu funkiirabu commented Jan 26, 2026

Note

Major documentation enhancements for deployment and frontend specs.

  • Deployment guide: Replace custom Display updates with standard Sui 0x2::display calls, add commit step, and include a concrete testnet example; introduce a clear Testing Order flowchart; expand Backer steps (coin selection/split, saving SupporterPass), add Issuer revenue simulation, and enrich the testnet checklist with phased testing.
  • Frontend spec: Add a new Points Program section covering goals, architecture, tracked events, point rules (testnet/mainnet), multipliers, DB schema, quests, REST APIs, frontend components (dashboard/leaderboard/quests/referrals), an example event processor, timeline, and security considerations.

Written by Cursor Bugbot for commit 7b72a7e. This will update automatically on new commits. Configure here.

@funkiirabu funkiirabu merged commit 0795fbf into main Jan 26, 2026
1 check passed
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on February 18

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment thread spec/frontend-spec.md
'RewardsClaimed': () => 5,
'RewardsClaimedMany': (e) => 5 * e.pass_count,
'SaleListingCreated': () => 10,
'SaleListingPurchased': (e) => Math.floor(e.price / 1_000_000_000) * 0.01,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marketplace points always zero for purchases under 100 SUI

Medium Severity

The marketplace points calculation produces fractional values that get floored to zero for normal purchase amounts. Line 2435 calculates Math.floor(price_in_sui) * 0.01 which yields 0.1 points for a 10 SUI purchase. Line 2449 then applies Math.floor(basePoints * multiplier), flooring 0.1 to 0. Any marketplace purchase under 100 SUI would award zero points despite the spec stating "1% of sale price" as the reward. This effectively disables marketplace points for typical transactions.

Additional Locations (1)

Fix in Cursor Fix in Web

@funkiirabu funkiirabu deleted the feat/deepbook branch February 5, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant