Typecheck a literal dict key#264
Merged
Merged
Conversation
Track a string literal's value as a `str` refinement (TKStrLit) so a `get` with a statically known key resolves a shape field the same way the `:name` getter does. `httpGet? "body" get?` now type-checks as `bytes` instead of the union of every response field. Because the value rides the stack as a type, it also resolves when the key reaches `get` through a variable, not only when written inline. The literal is a subtype of `str`: `unify` and every container constructor widen it back to `TidStr`, so it behaves as `str` everywhere else and never escapes into lists, dicts, shapes, unions, or match subjects. Programs without string literals are unaffected; string-heavy programs allocate less, since literal-key resolution avoids the shape-to-union collapse the generic `get` path performs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Exercises both the inline `"field" get?` and the variable-bound `"field" k! ... @k get?` forms on a heterogeneous shape in the shared success suite (type-checked and executed). Because the fields differ in type, `count` must resolve to `int` specifically for `2 +` to type-check — a dynamic key would type as `int | str` and be rejected — so the test guards against a resolution regression. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.