Bugfix: mock method to increment costs#298
Merged
Merged
Conversation
vitaglianog
changed the title
claire-mao
pushed a commit
that referenced
this pull request
May 1, 2026
* Added mock method to increment costs * bump version --------- Co-authored-by: Matthew Russo <mdrusso@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug when using Abacus optimizer without progress bar.
Bug was triggered since MAB Execution strategy calls:
self.progress_manager.incr_overall_progress_cost(val_gen_stats.cost_per_record)But when
progressis False in the runtime configuration, theMockProgressManagerdoes not expose that function.This fix is simple enough but maybe in future
incr_overall_progress_costmay be defined by theProgressManagerclass.