Skip to content

fix: update sitemap URL and enhance SEO metadata for sign-in page #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitekk merged 1 commit into from
Apr 19, 2026
Merged

fix: update sitemap URL and enhance SEO metadata for sign-in page #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/public/robots.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ Disallow: /auth/syncing
Allow: /auth/sign-in
Allow: /

Sitemap: https://mashov.mitya/sitemap.xml
Sitemap: https://mashov.mitya.dev/sitemap.xml
7 changes: 6 additions & 1 deletion frontend/src/app/auth/sign-in/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,15 @@ import type { Metadata } from 'next';
import SignInPageClient from './SignInPageClient';

export const metadata: Metadata = {
title: 'ื›ื ื™ืกื”',
title: 'ื›ื ื™ืกื” ืœืžืจื›ื– ื”ื•ืจื™ื',
description: 'ื”ืชื—ื‘ืจื• ืœืžืจื›ื– ื”ื•ืจื™ื โ€” ืฆืคื• ื‘ืฆื™ื•ื ื™ื, ืฉื™ืขื•ืจื™ ื‘ื™ืช ื•ื”ื•ื“ืขื•ืช ืฉืœ ื™ืœื“ื›ื ื“ืจืš ืžืขืจื›ืช ืžืฉื•ื‘',
alternates: {
canonical: '/auth/sign-in',
},
openGraph: {
title: 'ื›ื ื™ืกื” | ืžืจื›ื– ื”ื•ืจื™ื',
description: 'ื”ืชื—ื‘ืจื• ืœืžืจื›ื– ื”ื•ืจื™ื โ€” ืฆืคื• ื‘ืฆื™ื•ื ื™ื, ืฉื™ืขื•ืจื™ ื‘ื™ืช ื•ื”ื•ื“ืขื•ืช ืฉืœ ื™ืœื“ื›ื ื“ืจืš ืžืขืจื›ืช ืžืฉื•ื‘',
},
robots: {
index: true,
follow: true,
Expand Down
22 changes: 21 additions & 1 deletion frontend/src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const assistant = Assistant({
});

export const metadata: Metadata = {
metadataBase: new URL('https://mashov.mitya'),
metadataBase: new URL(process.env.NEXT_PUBLIC_BASE_URL ?? 'https://mashov.mitya.dev'),
title: {
default: 'ืžืจื›ื– ื”ื•ืจื™ื',
template: '%s | ืžืจื›ื– ื”ื•ืจื™ื',
Expand Down Expand Up @@ -52,6 +52,22 @@ interface RootLayoutProps {
children: React.ReactNode;
}

const jsonLd = {
'@context': 'https://schema.org',
'@type': 'WebApplication',
name: 'ืžืจื›ื– ื”ื•ืจื™ื',
url: process.env.NEXT_PUBLIC_BASE_URL ?? 'https://mashov.mitya.dev',
description: 'ืžืžืฉืง ืžืื•ื—ื“ ืœื ืชื•ื ื™ ื‘ื™ืช ื”ืกืคืจ โ€” ืฆื™ื•ื ื™ื, ืฉื™ืขื•ืจื™ ื‘ื™ืช, ื•ืžืกืจื™ื',
inLanguage: 'he',
applicationCategory: 'EducationApplication',
operatingSystem: 'All',
offers: {
'@type': 'Offer',
price: '0',
priceCurrency: 'ILS',
},
};

export default function RootLayout({ children }: RootLayoutProps) {
const themeBootstrap = `
(() => {
Expand All @@ -73,6 +89,10 @@ export default function RootLayout({ children }: RootLayoutProps) {
<html lang="he" dir="rtl" suppressHydrationWarning>
<head>
<script dangerouslySetInnerHTML={{ __html: themeBootstrap }} />
<script
type="application/ld+json"
dangerouslySetInnerHTML={{ __html: JSON.stringify(jsonLd) }}
/>
</head>
<body className={`${assistant.className} ${assistant.variable}`}>
<Providers>{children}</Providers>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/sitemap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { MetadataRoute } from 'next';
export default function sitemap(): MetadataRoute.Sitemap {
return [
{
url: 'https://mashov.mitya/auth/sign-in',
url: `${process.env.NEXT_PUBLIC_BASE_URL ?? 'https://mashov.mitya.dev'}/auth/sign-in`,
lastModified: new Date(),
changeFrequency: 'yearly',
priority: 1,
Expand Down
Loading