Accept TAB command separators - #107
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, well-scoped, and includes a targeted regression test for the new TAB-separator behavior.
Pull request overview
This PR updates NNTP request parsing so that a TAB (\t) is accepted as a valid command separator (in addition to the existing space separator), while preserving existing behavior for space-separated commands.
Changes:
- Update
RequestLine::parseto split on either space or TAB. - Add a regression test ensuring a TAB-separated
ARTICLEcommand is parsed identically to the space-separated form for kind/args/message-id routing.
File summaries
| File | Description |
|---|---|
src/protocol/request.rs |
Accept TAB as a request verb/args separator and add a unit test covering the new behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
beb575e to
8526697
Compare
9bc367d to
61d9a3f
Compare
Summary
Branch-added tests