Skip to content

Accept TAB command separators - #107

Merged
mjc merged 2 commits into
nntpp-31-cache-section-mergefrom
nntpp-32-tab-command-separator
Sep 11, 2026
Merged

Accept TAB command separators#107
mjc merged 2 commits into
nntpp-31-cache-section-mergefrom
nntpp-32-tab-command-separator

Conversation

@mjc

@mjc mjc commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • recognize TAB as a legal command separator in borrowed request parsing
  • keep existing space-separated command behavior unchanged

Branch-added tests

  • A parser regression test feeds a command line separated by TAB and verifies the command and arguments are split exactly as for a space.
  • The request parser suite continues to cover malformed, empty, and multi-argument lines.

Copilot AI lite review requested due to automatic review settings September 5, 2026 21:48
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8d807d17-535b-4818-8214-b4886348ea06

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal, well-scoped, and includes a targeted regression test for the new TAB-separator behavior.

Pull request overview

This PR updates NNTP request parsing so that a TAB (\t) is accepted as a valid command separator (in addition to the existing space separator), while preserving existing behavior for space-separated commands.

Changes:

  • Update RequestLine::parse to split on either space or TAB.
  • Add a regression test ensuring a TAB-separated ARTICLE command is parsed identically to the space-separated form for kind/args/message-id routing.
File summaries
File Description
src/protocol/request.rs Accept TAB as a request verb/args separator and add a unit test covering the new behavior.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mjc
mjc force-pushed the nntpp-31-cache-section-merge branch from beb575e to 8526697 Compare September 5, 2026 23:28
@mjc
mjc force-pushed the nntpp-32-tab-command-separator branch from 9bc367d to 61d9a3f Compare September 5, 2026 23:28
@mjc
mjc merged commit 4c0a6d5 into nntpp-31-cache-section-merge Sep 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants