Frame XHDR responses with the correct status code

[mjc]

Summary

• recognize XHDR’s 221 multiline success response independently from HDR’s 225 response
• route fragmented XHDR replies through the production framer

Branch-added tests

• A fragmented XHDR response pauses before the deferred reply and verifies the 221 response completes and preserves ordered emission through the production framing path.
• Existing HDR, multiline, and deferred-response ordering tests remain green.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: fb14c2c2-5070-4189-b0bb-aef47772a376

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟡 Changes recommended

The change drops multiline handling for XHDR status 225, which can cause mis-framing if a backend returns 225 for XHDR (a behavior also reflected in the repo’s response-code reference).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adjusts NNTP multiline framing rules so XHDR success responses are recognized with the correct status code, ensuring fragmented XHDR replies are routed through the production multiline framer and preserve deferred-reply ordering.

Changes:

• Treat XHDR success status 221 as a multiline body response (separate from HDR’s 225 mapping).
• Add a regression test to ensure a fragmented XHDR 221 response completes correctly before a deferred reply is emitted.

File summaries

File	Description
src/session/multiline_framing.rs	Adds a test covering fragmented XHDR 221 replies and deferred-response ordering through the production framing path.
src/protocol/request.rs	Updates the request/status → multiline-body mapping so XHDR is recognized as multiline on 221.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.