Skip to content

fix: bound stateful upstream request window - #123

Merged
mjc merged 1 commit into
mainfrom
fix/upstream-window
Sep 14, 2026
Merged

mjc merged 1 commit into
mainfrom
fix/upstream-window

Conversation

@mjc

@mjc mjc commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep up to 16 validated stateful requests in one upstream write window
  • flush before backend reads and at the bound while preserving response ordering
  • add a proof test where the backend waits for two commands before replying
  • add matched stateful and per-command proxy benchmarks

Evidence

  • nextest: 2278/2278 passed
  • clippy with all features and warnings denied passed
  • stateful pair median: 55.42 us
  • per-command pair median: 66.27 us
  • stateful pair: 2.364 GB/s; per-command pair: 1.977 GB/s

All commits are GPG-signed.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 91d68dcc-35ce-4719-849c-028976a612d7

📥 Commits

Reviewing files that changed from the base of the PR and between 03ea015 and 09ee30e.

📒 Files selected for processing (2)
  • benches/end_to_end_proxy.rs
  • src/session/handlers/stateful.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mjc
mjc force-pushed the fix/upstream-window branch from 74a7a6a to 09ee30e Compare September 14, 2026 02:48
@mjc
mjc merged commit 54004ed into main Sep 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant