Update OAuth2 redirect URIs to use constants#2
Open
jose4000 wants to merge 1 commit into
Open
Conversation
Contributor
|
tradingwizard
pushed a commit
to tradingwizard/DERIV-SITE-TEST
that referenced
this pull request
Jun 17, 2026
… errors
Task: After login users saw a broken/static dashboard with no demo/real
accounts and could not trade. Root cause: the dashboard-side authorize()
(OTP -> OTP-authenticated WS connect) hung forever, and legacy VR/CR loginid
logic no longer matches Deriv's NEW platform account shapes.
Changes:
- deriv-ws-adapter.ts: connect() now rejects on close-before-open and after a
15s timeout (was hanging indefinitely); added connectWithOtpRetry() which
fetches a FRESH single-use OTP per attempt with backoff; authorize() uses it.
- App.tsx: replaced legacy startsWith('VR')/'CR') demo/real selection with
account_type-based isVirtual logic (new IDs like DOT90004580); removed now
unused imports.
- callback-page.tsx: clientAccounts entries now persist account_type.
- CoreStoreProvider.tsx: added effect that surfaces a plain-language, retryable
error ("Try again" reload) when a logged-in user's authorization finishes
without success; clears on success. Guarded against logged-out false positives.
- server/index.js: added status/error-body diagnostics for accounts + OTP
proxies (no tokens logged).
Verification: dev server compiles all changed files; /dashboard renders without
crash. Architect review passed (no severe issues). Live OAuth (demo+real) login
and trade path cannot be tested in this environment — covered by follow-up
Task mkaaru#2. Logged-out public market-data protocol errors are out of scope (Task mkaaru#3).
Note: pre-existing tsc errors in CoreStoreProvider (api_base.api possibly null)
and an unused `bearer` field are unrelated to this change and not introduced here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i did some authentication changes