Bugfix/multi issue fixes#3
Open
makoti942 wants to merge 99 commits into
Open
Conversation
added 30 commits
January 15, 2026 12:11
Updated the LOCALHOST APP_IDS constant in config.ts to 101585. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 5ffbc67f-3efb-4c3d-bce1-15ba21b4c15c Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 5ece81da-b5e1-43d4-bf4d-66e297bc9bc5 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Commit-Deployment-Build-Id: e7f89367-bcfa-4a22-9ef4-35cd3cd69d19 Replit-Helium-Checkpoint-Created: true
Modify redirect callback URIs and post-logout redirect URIs in header component and OAuth2 hook to use the specified Replit app URL instead of dynamically generated origin. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 4addc523-41b9-4d46-8c25-025a60f05f31 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: b58a9166-2c9b-422c-979a-5a90ca8c1dcb Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Commit-Deployment-Build-Id: 232b3c96-e465-45c2-ac33-c191cd77934c Replit-Helium-Checkpoint-Created: true
Remove `isLocal()` check from `isTestLink` in `config.ts` to ensure correct redirect to the live Replit URL instead of `localhost`. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 2d28c5d8-a09f-4cfb-ad5c-ecfa8cf63a2e Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 5e2343f0-d4b6-4d9a-bb57-4cc177dddbc0 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Commit-Deployment-Build-Id: 7c55b6d0-0e89-4ec9-9067-adc742c67014 Replit-Helium-Checkpoint-Created: true
…ion page Update login URL generation logic to always use the OAuth domain for redirects, ensuring users are sent to the correct Deriv authorization page. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 87f1e166-9a65-4341-bc80-8ff4901b5fe1 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 716d38fc-0dea-418a-b1dd-85189fa77867 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Commit-Deployment-Build-Id: 3d08d3c6-d741-4944-b698-e69e48d0f196 Replit-Helium-Checkpoint-Created: true
Replaced all instances of 'localhost' with 'replit.app' in allowed domains and redirect logic within `brand.ts`, `useTMB.ts`, and `traders-hub-redirect.ts`. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 57e0df2e-bdd3-43f9-84b8-b66660b234f2 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 746f3c38-5a5c-4e2c-b220-63ca006b275b Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/pylFwuW Replit-Commit-Deployment-Build-Id: 945a474a-f3cb-41fa-8bab-e05eb016c393 Replit-Helium-Checkpoint-Created: true
Update brand, TMB hook, and traders hub redirect utilities to explicitly include and recognize the full 'yasin--yassinmakate318.replit.app' domain for correct environment detection and redirection. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 300a2b51-3898-4ad5-9c44-5167ff30e6ed Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 6e85287d-ed2f-485f-82e5-eb802f8e5fa6 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Commit-Deployment-Build-Id: 688aa986-fdb0-4066-b16a-a8224acec26c Replit-Helium-Checkpoint-Created: true
Updates SCSS theme constants to use orange instead of red, and modifies authentication redirect logic in config.ts to correctly handle Replit and local environments. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: intermediate_checkpoint Replit-Commit-Event-Id: acf25089-eaf0-4e3b-8db6-5e5068173801 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 5171bcf5-b391-4db2-a971-db30c97cea87 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 70376bfb-4258-43cd-b5b8-d2c385e74290 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Commit-Deployment-Build-Id: 0bbda7f4-e463-41be-a078-cf42db5086a8 Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 13335630-6001-4f2e-8dff-2250dd7b2a6c Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Commit-Deployment-Build-Id: 695769b6-5fee-4b2e-b878-4429523e940b Replit-Helium-Checkpoint-Created: true
Disable the isLocal() check entirely in the config utility to prevent any fallback to localhost, ensuring the application consistently uses the specified Replit domain for all operations. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 159b5da7-945b-43aa-b10c-383d8c029544 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: c557b670-5ae6-48e5-9461-2ecdee1dea2a Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Commit-Deployment-Build-Id: 2ab6d52c-073a-42a8-8db3-b3c6feef7ccb Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 72086bdd-e457-491e-84c5-b7ebaccc280c Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Commit-Deployment-Build-Id: 7a1f03b6-8484-45ce-bedf-3eed9263a654 Replit-Helium-Checkpoint-Created: true
…lit domain Updates the production App ID to 101585 and modifies the domain validation to include the Replit domain for proper redirection. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 0de6bce6-bab1-4f5c-8ac4-751d406352f8 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/N1XZEab Replit-Helium-Checkpoint-Created: true
Update application URLs to use the Replit domain, disable local environment checks, and adjust styling for a dark theme with orange accents. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: intermediate_checkpoint Replit-Commit-Event-Id: d4d2c47a-36d5-49cf-84f0-26135dff2042 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 0c211373-806b-4b2b-b6e5-662b85ddf8d1 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 9dd482b7-aa7e-48b1-9eba-ea6b1737a529 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Commit-Deployment-Build-Id: 7e0e9fe3-2391-4022-9df1-e7b8b6b11f1b Replit-Helium-Checkpoint-Created: true
Replaces Deriv branding with "MAKOTI TRADERS", changes accent colors to green, and ensures all authentication redirects point to the specified custom domain instead of localhost. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: intermediate_checkpoint Replit-Commit-Event-Id: 79c3dead-e7bb-4c78-a397-27b7b16f9c73 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Helium-Checkpoint-Created: true
Update the header to display "MAKOTI TRADERS", change the primary color to green, and ensure all redirects point to the live domain. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 07368e12-6956-4759-9ecf-1e8d91209afd Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Helium-Checkpoint-Created: true
Update configuration files to replace localhost references with the specified Replit domain (https://yasin--yassinmakate318.replit.app) and set the appropriate App ID for non-production environments. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: intermediate_checkpoint Replit-Commit-Event-Id: fa78e2ac-ffbc-452b-ae48-9c783b610108 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 0c21b0b8-f7be-4564-91f3-d402b3698655 Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: f8de5211-2e57-407c-aa11-28432a23d20b Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Commit-Deployment-Build-Id: 1274941b-5d42-494c-9160-7a9edd746cb6 Replit-Helium-Checkpoint-Created: true
Replit-Commit-Author: Deployment Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: full_checkpoint Replit-Commit-Event-Id: 4909a318-2c08-45d9-8de8-309f797eb06f Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Commit-Deployment-Build-Id: 84a2d453-50ef-4572-ace7-155100adb66e Replit-Helium-Checkpoint-Created: true
…e build output Modify package.json scripts to explicitly set NODE_ENV to production for start and build commands, and update the serve script to use http-server with a default port and listen on all interfaces. Replit-Commit-Author: Agent Replit-Commit-Session-Id: 2149c84b-5a92-4f99-966c-cfca4376d4dd Replit-Commit-Checkpoint-Type: intermediate_checkpoint Replit-Commit-Event-Id: 46ce35a2-f913-4505-a495-beb5c9f840ff Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/c5d599d7-71a4-412e-b8d8-5bbc6d218ff4/2149c84b-5a92-4f99-966c-cfca4376d4dd/qR5x0dp Replit-Helium-Checkpoint-Created: true
Contributor
|
tradingwizard
pushed a commit
to tradingwizard/DERIV-SITE-TEST
that referenced
this pull request
Jun 17, 2026
… errors
Task: After login users saw a broken/static dashboard with no demo/real
accounts and could not trade. Root cause: the dashboard-side authorize()
(OTP -> OTP-authenticated WS connect) hung forever, and legacy VR/CR loginid
logic no longer matches Deriv's NEW platform account shapes.
Changes:
- deriv-ws-adapter.ts: connect() now rejects on close-before-open and after a
15s timeout (was hanging indefinitely); added connectWithOtpRetry() which
fetches a FRESH single-use OTP per attempt with backoff; authorize() uses it.
- App.tsx: replaced legacy startsWith('VR')/'CR') demo/real selection with
account_type-based isVirtual logic (new IDs like DOT90004580); removed now
unused imports.
- callback-page.tsx: clientAccounts entries now persist account_type.
- CoreStoreProvider.tsx: added effect that surfaces a plain-language, retryable
error ("Try again" reload) when a logged-in user's authorization finishes
without success; clears on success. Guarded against logged-out false positives.
- server/index.js: added status/error-body diagnostics for accounts + OTP
proxies (no tokens logged).
Verification: dev server compiles all changed files; /dashboard renders without
crash. Architect review passed (no severe issues). Live OAuth (demo+real) login
and trade path cannot be tested in this environment — covered by follow-up
Task mkaaru#2. Logged-out public market-data protocol errors are out of scope (Task mkaaru#3).
Note: pre-existing tsc errors in CoreStoreProvider (api_base.api possibly null)
and an unused `bearer` field are unrelated to this change and not introduced here.
tradingwizard
pushed a commit
to tradingwizard/DERIV-SITE-TEST
that referenced
this pull request
Jun 17, 2026
Task mkaaru#3: Verify the new platform's public market-data WebSocket works for logged-out users (URL/auth scheme + req_id correlation), and fix anything that doesn't. Verification (probed the live endpoint directly with the `ws` package): - Public URL is CORRECT: wss://api.derivws.com/trading/v1/options/ws/public?app_id=... The `/public` suffix is required (without it -> HTTP 404). - req_id IS echoed on every response (and echo_req is present), so request correlation is solid; the msg_type fallback is only a harmless safety net. No correlation hardening needed. - Logged-out market data works: active_symbols (78 symbols, new field names), ticks_history candles, ticks streaming, trading_times, contracts_for (by symbol), time, ping, forget, forget_all all succeed. - Only two legacy system calls are unsupported on the new platform: website_status and residence_list (both -> UnrecognisedRequest). contracts_for must NOT include `currency` (the app's real call path doesn't). Changes (the one real logged-out defect was the website_status rejection): - deriv-ws-adapter.ts websiteStatus(): attempt the call but degrade to a benign { website_status: {} } on failure instead of rejecting. The new public socket replies UnrecognisedRequest, which previously surfaced as an uncaught console error for logged-out users. Kept the send so an authenticated socket that supports it still works; currency/country lookups already have fallbacks. - CoreStoreProvider.tsx: added a defensive .catch() on the websiteStatus() call so it can never become an unhandled rejection. No change to connectPublic() (URL already correct) and no correlation changes (req_id confirmed echoed). Verified: restarted Dev Server, /dashboard loads for logged-out users (WS connected, live server time), browser console is clean (no UnrecognisedRequest, no uncaught rejections). Out of scope (left untouched): loader-resolution/null-store crash (Task mkaaru#5); residence_list-based geo-block is an effectively-dead edge path on the new platform and not worth changing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.