Skip to content

Fix type comparison #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkofler96 merged 2 commits into from
Jul 8, 2026
Merged

Fix type comparison #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7208fd8
Fix type comparison
Jul 7, 2026
d89e034
Add previous type checks for compatibility reasons
Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions DeepSDFStruct/optimization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,18 @@ def get_mesh_from_torchfem(Solid: torchfem.Solid) -> pyvista.UnstructuredGrid:
if not isinstance(Solid, torchfem.Solid):
raise NotImplementedError("Currently only solid mesh is supported.")
# VTK cell types
if Solid.etype is Tetra1:
cell_types = Solid.n_elem * [pyvista.CellType.TETRA]
elif Solid.etype is Tetra2:
cell_types = Solid.n_elem * [pyvista.CellType.QUADRATIC_TETRA]
elif Solid.etype is Hexa1:
cell_types = Solid.n_elem * [pyvista.CellType.HEXAHEDRON]
elif Solid.etype is Hexa2:
cell_types = Solid.n_elem * [pyvista.CellType.QUADRATIC_HEXAHEDRON]
etype = Solid.etype

if etype is Tetra1 or isinstance(etype, Tetra1):
cell_types = [pyvista.CellType.TETRA] * Solid.n_elem
elif etype is Tetra2 or isinstance(etype, Tetra2):
cell_types = [pyvista.CellType.QUADRATIC_TETRA] * Solid.n_elem
elif etype is Hexa1 or isinstance(etype, Hexa1):
cell_types = [pyvista.CellType.HEXAHEDRON] * Solid.n_elem
elif etype is Hexa2 or isinstance(etype, Hexa2):
cell_types = [pyvista.CellType.QUADRATIC_HEXAHEDRON] * Solid.n_elem
else:
raise TypeError(f"Unsupported element type: {etype} ({type(etype)})")

# VTK element list
el = len(Solid.elements[0]) * torch.ones(Solid.n_elem, dtype=Solid.elements.dtype)
Expand Down
Loading