Skip to content

[WIP] Add UV parametric tessellation for conical surface faces - #55

Closed
mkofler96 with Claude wants to merge 1 commit into
mainfrom
claude/add-uv-parametric-tessellation
Closed

[WIP] Add UV parametric tessellation for conical surface faces#55
mkofler96 with Claude wants to merge 1 commit into
mainfrom
claude/add-uv-parametric-tessellation

Conversation

@Claude

@Claude Claude AI commented May 15, 2026

Copy link
Copy Markdown

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>tess: UV parametric tessellation for CONICAL_SURFACE faces</issue_title>
<issue_description>## Problem

22 bracket faces use CONICAL_SURFACE (tapered transitions between features of different radii). All fall through to the flat-projection path and are tessellated as flat polygons — conical geometry is flattened instead of preserving the taper angle.

What the fix looks like

Add try_tessellate_conical, analogous to try_tessellate_cylindrical:

  1. Detect CONICAL_SURFACE — parse axis, radius (at v=0), and semi_angle.
  2. Sample the boundary to find the v-range (distance along the cone's slant).
  3. Determine the angular u-range from the boundary points — check for a closed-circle edge to detect full-revolution cones vs. partial arcs.
  4. For full-revolution cones: generate a UV grid (u = angle 0..2π, v = slant distance), evaluate ConicalSurface::point(u, v) for each grid vertex.
  5. For partial cones: invert boundary points to UV, triangulate in UV, lift back.

The parametric equation is already implemented in ConicalSurface::point:

P(u,v) = origin + (radius + v·sin(φ))·(cos(u)·x + sin(u)·y) + v·cos(φ)·z

Affected code

  • crates/kofem-geom/src/tess/mod.rs — add try_tessellate_conical
  • crates/kofem-geom/src/geom/surface.rsConicalSurface::point already implemented

Impact

22 faces — conical transitions and chamfers on the bracket.</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

@Claude Claude AI linked an issue May 15, 2026 that may be closed by this pull request
Copilot stopped work on behalf of mkofler96 due to an error May 15, 2026 21:19
@Claude
Claude AI requested a review from mkofler96 May 15, 2026 21:19
@mkofler96 mkofler96 closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tess: UV parametric tessellation for CONICAL_SURFACE faces

2 participants