spec: triage owns backfilling a missing scope label - #402
Merged
Merged
Conversation
#401 said triage sets a scope label on every issue, but its trigger is "new issue opened" — which left the 52 issues that predate the label with nobody responsible for them, and made the backfill a one-off migration the spec did not describe. Triage now sets a missing scope label on any issue it touches, regardless of the issue's age. Framed as a standing rule rather than a migration, because the label can also go missing later: a human editing labels by hand drops one, and there is no reason for the rule to expire. Deliberately bounded to one label and one line of comment. A missing label already reads as `tier-1` and gets checked, so this never unblocks anything — it converts a correct-but-expensive default into a cheap one. That does not justify re-triaging the issue's spec, and the wording says so, because "while you are here" is how a cheap rule turns into an expensive one. +68 bytes to AGENTS.md, +658 to triage.md (triage sessions only). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nz6t5FtUc5zco8eunf5hAx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gap I flagged when #401 merged: the spec said triage labels every issue, but triage's trigger is "new issue opened", so the 52 issues predating the label had nobody responsible for them.
Change
Triage sets a missing scope label on any issue it touches, whatever its age — one label, one line of comment.
Written as a standing rule, not a migration with an end date, because the label can go missing later too: a human editing labels by hand drops one, and nothing about the rule should expire.
Why it never blocks
A missing label already reads as
tier-1and gets checked. So this is not fixing a correctness hole — it converts a correct-but-expensive default into a cheap one. The wording says that explicitly, and bounds the work to the label plus one comment, because "while you're here" is how a cheap rule becomes an expensive one.Cost
.agents/AGENTS.md.agents/triage.mdAlready done by hand
The four issues behind the open PRs are labelled, and the five labels exist:
tier-1measurement/sweep.rs,report.rstier-1measurement/sweep.rs,report.rsscope-noneBoth
tier-1PRs touchsweep.rs, which carries a Farina / ISO 18233:2006 Annex B citation in the restored document map — so the standards check has real content there, not just a true regex.#369 is the one judgement call. It is labelled
measurement-accuracyand concerns τ calibration, so it looks tier-1. Its diff touches no standards-governed module, and the correctness question — does the xrun counter get checked — is code logic no standard resolves. The spec's "unsure →tier-1" bias is written for triage predicting ahead of a diff; here the diff is final, so I called it from the diff. Flip it withgh issue edit 369 --remove-label scope-none --add-label tier-1if you disagree.The remaining ~48 open issues are deliberately left unlabelled — this PR is what picks them up as triage reaches them.