Skip to content

feat: Sponsor button and dialog, with a README sponsor section - #41

Merged
mkpoli merged 9 commits into
mainfrom
feat/sponsor-button
Nov 2, 2026
Merged

mkpoli merged 9 commits into
mainfrom
feat/sponsor-button

Conversation

@mkpoli

@mkpoli mkpoli commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

TL;DR: Sponsor. A Sponsor button opens a tip dialog with the official Ko-fi mark, and the README gains a matching sponsor section.

ELI5: A small Sponsor pill with the author's face sits in the header. It opens a dialog that says who builds the site, how a tip helps, and how to send one through Ko-fi. The README says the same in a short section with the Ko-fi badge.

flowchart LR
  P[Sponsor pill] --> D[Sponsor dialog] --> K[Ko-fi, official mark]
  README --> S[Sponsor section] --> K
Loading

Folds in #42; each section below keeps that PR's own details and screenshots.

#41: feat: add a Sponsor button and dialog

Details

  • site/public/index.html (the page served at kureedo.mkpo.li): the pill is the first item of a new .mast-actions group with the theme toggle. Below 720px it is a face-only circle and the group moves above the wordmark, so "クレード" does not wrap. The dialog is a modal <dialog> opened with showModal(); a backdrop click closes it only outside its box, Esc closes it, and focus returns to the pill.
  • Theme: --sp-* colour tokens are defined in the page's three theme blocks (light, prefers-color-scheme: dark, data-theme="dark"), so the pill and dialog follow the existing toggle. The dialog uses the page's --panel, --ink, --muted and --shadow. All rules are prefixed sponsor- and scoped under .sponsor-dialog where they would meet the page's global h2, a and p styles.
  • Wording: the page shows Japanese with English beneath, so the dialog does the same. The copy presents Kureedo as a free tool and a tip as time to improve it; the ask names no service.
  • Motion sits under prefers-reduced-motion: no-preference; paddings and badge offsets use logical properties.
  • site/public/sponsor/sponsor-face.webp (96px) and sponsor-portrait.webp (320px) are the portrait crops; site/README.md mentions the folder and the brand file.
  • Ko-fi button: the official Ko-fi mark (site/public/brand/kofi-symbol.svg) on a #202020 button with a #202020 border in light and a translucent white border in dark; white text on #202020 is well above 4.5:1. Pink text uses #c2185b on light and #ff8fb5 on dark surfaces.
  • Ko-fi says supporters need no account (Supporter payments FAQ). Card checkout appears only if the creator has connected Stripe (payment methods), which was not confirmed on the live page.

Screenshots (2x)

Before is origin/main; after is this branch. The page shows Japanese with English beneath, so each shot carries both.

Before After
Wide, light
Wide, dark
Phone, light
Phone, dark

Dialog:

Phone, scrolled to the Ko-fi button:

Verification

  • The site is static with no build, type check or test script; the page was checked in headless Chromium at 1280px and 390px, light and dark.
  • Esc closes the dialog and focus returns to the pill; a click on the backdrop closes it.

#42: docs: add a sponsor section to the README

Changes

  • README: new Sponsor section, placed before Licence.

Summary by CodeRabbit

  • New Features
    • Added a Sponsor button that opens a dialog with Ko-fi and company sponsorship links.
    • The dialog closes using its close button or an outside click, and focus returns to the Sponsor button when closed.
    • Added theme-aware colors, responsive styling, visible focus outlines, and motion effects that respect reduced-motion settings.
  • Documentation
    • Added sponsorship information, including Ko-fi and OFUSE tip options and a company sponsorship contact.
    • Documented the sponsor images and Ko-fi mark used in the dialog.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9dd30367-888c-42a5-aca4-b6a073c188ac
Commits

Reviewing files that changed from the base of the PR and between de472b4 and 8766d15.

Files selected for processing: 1
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The site adds a sponsor button beside the theme control. The button opens a bilingual sponsorship dialog with payment and company-contact links. The dialog closes through its close button or an outside click, then returns focus to the sponsor button.

Changes: Sponsor interface

Layer / File(s) Summary
Sponsor button and masthead presentation
site/public/index.html
The masthead groups the sponsor and theme buttons. Sponsor styles define theme colors, responsive layout, keyboard focus, and animations that run only when reduced motion is not preferred.
Dialog content and controls
site/public/index.html, site/README.md, README.md
The dialog contains bilingual sponsorship information, payment instructions, and contact links. Its controls open and close the dialog, and closing returns focus to the sponsor button. The READMEs describe the sponsorship options and identify the portrait crop and Ko-fi mark.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Visitor
  participant SponsorButton
  participant SponsorDialog
  participant SponsorshipLink
  Visitor->>SponsorButton: Click sponsor button
  SponsorButton->>SponsorDialog: Open dialog
  Visitor->>SponsorshipLink: Follow Ko-fi or company-contact link
  Visitor->>SponsorDialog: Click close button or outside
  SponsorDialog->>SponsorButton: Restore focus
Loading
Merge Risk: Minimal · up to 8766d

The sponsor controls and dialog are implemented with no established merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat: Sponsor button and dialog, with a README sponsor section" matches the main change. The PR adds a Sponsor button and modal dialog to the static landing page, and a README sponsor secti…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat: Sponsor button and dialog, with a README sponsor section" matches the main change. The PR adds a Sponsor button and modal dialog to the static landing page, and a README sponsor section. It names the two main parts of the changeset, so it is fully related. It is specific and concise, and it follows the conventional commit style. It does not cover details such as the responsive layout or the portrait assets, which is acceptable.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@mkpoli mkpoli changed the title feat: add a Sponsor pill and dialog fix: reword the Sponsor dialog as a tip request Oct 30, 2026
@mkpoli mkpoli changed the title fix: reword the Sponsor dialog as a tip request feat: add a Sponsor button and dialog Oct 30, 2026
@mkpoli mkpoli changed the title feat: add a Sponsor button and dialog feat: Sponsor button and dialog, with a README sponsor section Nov 2, 2026
@mkpoli
mkpoli merged commit c78c6eb into main Nov 2, 2026
3 checks passed
@mkpoli
mkpoli deleted the feat/sponsor-button branch November 2, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant