Repository navigation
feat: Sponsor button and dialog, with a README sponsor section - #41
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Sponsor button and masthead presentation site/public/index.html |
The masthead groups the sponsor and theme buttons. Sponsor styles define theme colors, responsive layout, keyboard focus, and animations that run only when reduced motion is not preferred. |
Dialog content and controls site/public/index.html, site/README.md, README.md |
The dialog contains bilingual sponsorship information, payment instructions, and contact links. Its controls open and close the dialog, and closing returns focus to the sponsor button. The READMEs describe the sponsorship options and identify the portrait crop and Ko-fi mark. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant Visitor
participant SponsorButton
participant SponsorDialog
participant SponsorshipLink
Visitor->>SponsorButton: Click sponsor button
SponsorButton->>SponsorDialog: Open dialog
Visitor->>SponsorshipLink: Follow Ko-fi or company-contact link
Visitor->>SponsorDialog: Click close button or outside
SponsorDialog->>SponsorButton: Restore focus
Merge Risk: 
Minimal · up to 8766d
-
The sponsor controls and dialog are implemented with no established merge-blocking risk.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title "feat: Sponsor button and dialog, with a README sponsor section" matches the main change. The PR adds a Sponsor button and modal dialog to the static landing page, and a README sponsor section. It names the two main parts of the changeset, so it is fully related. It is specific and concise, and it follows the conventional commit style. It does not cover details such as the responsive layout or the portrait assets, which is acceptable.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
TL;DR: Sponsor. A Sponsor button opens a tip dialog with the official Ko-fi mark, and the README gains a matching sponsor section.
ELI5: A small Sponsor pill with the author's face sits in the header. It opens a dialog that says who builds the site, how a tip helps, and how to send one through Ko-fi. The README says the same in a short section with the Ko-fi badge.
Folds in #42; each section below keeps that PR's own details and screenshots.
#41: feat: add a Sponsor button and dialog
Details
site/public/index.html(the page served at kureedo.mkpo.li): the pill is the first item of a new.mast-actionsgroup with the theme toggle. Below 720px it is a face-only circle and the group moves above the wordmark, so "クレード" does not wrap. The dialog is a modal<dialog>opened withshowModal(); a backdrop click closes it only outside its box, Esc closes it, and focus returns to the pill.--sp-*colour tokens are defined in the page's three theme blocks (light,prefers-color-scheme: dark,data-theme="dark"), so the pill and dialog follow the existing toggle. The dialog uses the page's--panel,--ink,--mutedand--shadow. All rules are prefixedsponsor-and scoped under.sponsor-dialogwhere they would meet the page's globalh2,aandpstyles.prefers-reduced-motion: no-preference; paddings and badge offsets use logical properties.site/public/sponsor/sponsor-face.webp(96px) andsponsor-portrait.webp(320px) are the portrait crops;site/README.mdmentions the folder and the brand file.site/public/brand/kofi-symbol.svg) on a#202020button with a#202020border in light and a translucent white border in dark; white text on#202020is well above 4.5:1. Pink text uses #c2185b on light and #ff8fb5 on dark surfaces.Screenshots (2x)
Before is
origin/main; after is this branch. The page shows Japanese with English beneath, so each shot carries both.Dialog:
Phone, scrolled to the Ko-fi button:
Verification
#42: docs: add a sponsor section to the README
Changes
Summary by CodeRabbit