Fix build breakage from rand_core 0.10.0 - #167
Merged
mkrueger merged 1 commit intoMar 28, 2026
Merged
Conversation
internal-russh-forked-ssh-key 0.6.16 (via russh 0.56.0) fails to compile with rand_core 0.10.0 which deprecated RngCore and moved its methods to TryRng/Rng. Since Cargo.lock is gitignored, fresh builds resolve to the breaking release. Vendor the crate with a patched RngAdapter that implements the new TryRng/TryCryptoRng traits. This can be removed once russh ships a new release (fix merged in Eugeny/russh#628). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
ty - just catching up. I'll update the project. |
|
Just my own $.02 on this... probably would have been better to reference the pending branch by name/githash in the cargo.toml over embedded the upstream repo... even forking and self-referencing over this vendoring solution. Just my own opinion, as now there's a massive external codebase embedded into this repository's history that really only needs to be temporary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rand_core 0.10.0(released 2026-02-01) deprecatedRngCoreand moved its methods to a newTryRng/Rngtrait hierarchyCargo.lockis gitignored, fresh builds resolverand_coreto0.10.0, which breaksinternal-russh-forked-ssh-key 0.6.16(viarussh 0.56.0→icy_net)internal-russh-forked-ssh-keywith a patchedRngAdapterthat implementsTryRng/TryCryptoRnginstead of the removedRngCoremethodsThe upstream fix is merged (Eugeny/russh#628) but unreleased. A fix to the ssh-key crate itself is also proposed (Eugeny/RustCrypto-SSH#2). The vendor patch can be removed once either ships a new release.
Test plan
cargo build --releasesucceeds🤖 Generated with Claude Code