Repository navigation
3.5.1: replace deprecated Shopify fields, and show product images - #20
Merged
Merged
Conversation
The templates asked Shopify for Product.featuredImage, Product.images, ShopPlan.displayName and Shop.billingAddress, all deprecated and due to be removed in a later API version. They now use featuredMedia, media, publicDisplayName and shopAddress. The Dashboard and Products pages read the new names. npm run check:graphql reports no deprecated field. Product search cards never showed an image: the search route returns the image as a URL and the page looked for an object. The page reads it now. Images are requested at the size they are shown, 600 pixels for a card and 800 for the detail view. They were the originals, up to 3908 pixels wide. Checked by running the template's route handlers, unstubbed, against a real development store on API 2026-10, and loading both pages on that data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four deprecated Shopify fields replaced in both templates. They still work in 2026-10, but a later API version will remove them.
Product.featuredImagefeaturedMediaProduct.imagesmediaShopPlan.displayNamepublicDisplayNameShop.billingAddressshopAddressGET /api/shopandGET /api/products/:idreturn the new names, and the Dashboard and Products pages read them.GET /api/products/searchkeeps its flatimagefield.Product search cards now show images. The search route returns
imageas a URL; the page looked forimage.src, so every card said "No image".Images are requested at display size: 600 pixels for a card, 800 for the detail view. They were the originals, up to 3908 pixels wide.
Released as 3.5.1 when this merges.
Test plan
nullwithout media or without a preview, and is asked for at a reduced size.npm run test:e2e: 58/58. Both templates build and pass their own 49 tests.npm run check:graphql: all 6 queries valid against 2026-10, with no deprecated field left.null.🤖 Generated with Claude Code