Fix ThreadPool stop flag data race in destructor#112
Open
Aristide021 wants to merge 1 commit intoml-explore:mainfrom
Open
Fix ThreadPool stop flag data race in destructor#112Aristide021 wants to merge 1 commit intoml-explore:mainfrom
Aristide021 wants to merge 1 commit intoml-explore:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a ThreadPool teardown data race on stop_threads_.
Workers read stop_threads_ under task_mutex_, but destructor wrote it without locking. That is an unsynchronized read/write (UB).
This PR writes stop_threads_ under task_mutex_ in ThreadPool.cpp (line 53), then notify_all() and join as before.
Validation:
Before fix: TSAN reports data race (ThreadPool.cpp:54, destructor write vs worker read).
After fix: same TSAN harness (5000 create/destroy loops) exits clean with no race report.