Repository navigation
test: ignore exchange_calendars' pandas 3.1 tz-values deprecation - #132
Merged
Merged
Conversation
pandas 3.1 deprecates Series.values dropping timezone information. exchange_calendars' ExchangeCalendar.__init__ (exchange_calendar.py:403) still does this, and with filterwarnings = error every test that builds a calendar fails on the Python 3.15 prerelease jobs, which install pandas 3.1.0rc0. pandas attributes the warning to pandas.core.series, so the filter is scoped by its exact message instead of the calling module. Under pandas 3.1.0rc0 all 20 occurrences in the suite come from that one exchange_calendars line. The warning-filter cap moves from five to six to admit it. Remove the filter once an exchange_calendars release stops calling Series.values on tz-aware series. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 3.15 prerelease jobs install pandas 3.1.0rc0, which deprecates
Series.valuesdropping timezone information (Pandas4Warning, aDeprecationWarningsubclass).exchange_calendars'ExchangeCalendar.__init__(exchange_calendar.py:403) still makes that call, so withfilterwarnings = errorevery test that builds a calendar fails. This is why the prerelease checks and the Compatibility Gate fail on main and on #131.pandas.core.seriesrather than the caller, so the message is what keeps it narrow.test_quality_gates.pyfrom 5 to 6.Verified locally with pandas 3.1.0rc0: the full suite passes (2213 passed, 13 skipped). With the warning turned back into an error, all 20 failures trace through that one
exchange_calendarsline and none through ml4t code. The default environment also passes.Remove the filter once an
exchange_calendarsrelease stops making the call.🤖 Generated with Claude Code