Skip to content

rm dead code#960

Merged
rrotter merged 2 commits intoproductionfrom
dkms
Mar 13, 2026
Merged

rm dead code#960
rrotter merged 2 commits intoproductionfrom
dkms

Conversation

@rrotter
Copy link
Member

@rrotter rrotter commented Mar 12, 2026

  • don't install dkms on all hosts
  • useless i40e test
  • unused hathitrust::prod profile

@rrotter
remove dead dkms related code
189714b 
- no reason to install dkms on every host
- rm useless i40e-dkms test
@rrotter rrotter requested a review from skorner March 13, 2026 13:43
@rrotter
Copy link
Member Author

rrotter commented Mar 13, 2026 •
edited
Loading

Review q's:

  • @skorner, any concern about the dkms change? It's a dependency of any dkms module anyway, so not clear to me why it was ever there, probably just copy pasta from an old runlist.
  • @aelkiss: fyi on the removed profiles

@rrotter
rm unused hathitrust manifests
ad2f838 
- role::hathitrust::prod
- profile::hathitrust::solr6::classic
@rrotter rrotter requested a review from aelkiss March 13, 2026 14:00
skorner
skorner approved these changes Mar 13, 2026
View reviewed changes
Copy link
Member

@skorner skorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concern, and these deletes all look good to me.

@rrotter rrotter merged commit ef2e745 into production Mar 13, 2026
7 checks passed
@rrotter rrotter deleted the dkms branch March 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skorner skorner skorner approved these changes

@aelkiss aelkiss Awaiting requested review from aelkiss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrotter @skorner