[Batch] Change batch step default for full_event to True#615
Merged
gtopper merged 14 commits intomlrun:developmentfrom Mar 3, 2026
Merged
[Batch] Change batch step default for full_event to True#615gtopper merged 14 commits intomlrun:developmentfrom
full_event to True#615gtopper merged 14 commits intomlrun:developmentfrom
Conversation
gtopper
reviewed
Mar 3, 2026
Collaborator
gtopper
left a comment
There was a problem hiding this comment.
Looks good overall, in line with the decision as cited in https://iguazio.atlassian.net/browse/ML-12099?focusedCommentId=207050.
Please update the PR title to reflect the fact that support isn't removed, but rather deprecated, with the default value changed.
Please make sure this change gets a release note.
Would be good to add a test for the deprecation warning itself, e.g.:
def test_batch_warns_when_full_event_not_specified():
with pytest.warns(FutureWarning, match="full_event"):
Batch(4, 100)While this is a concern we can defer, there are tests in storey and mlrun that would fail once Batch(full_event=False) is actually blocked. See test_to_dataframe_with_index and test_batch_by_user_key in storey, and test_batch in mlrun for examples.
full_event to True
gtopper
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update Batch step default to full_event=True.
It also updates all Batch steps tests to operate also with full events throughout.
ML-12099