Skip to content

[Batch] Change batch step default for full_event to True#615

Merged
gtopper merged 14 commits intomlrun:developmentfrom
tomerm-iguazio:disable_full_event_false_batch
Mar 3, 2026
Merged

[Batch] Change batch step default for full_event to True#615
gtopper merged 14 commits intomlrun:developmentfrom
tomerm-iguazio:disable_full_event_false_batch

Conversation

@tomerm-iguazio
Copy link
Collaborator

@tomerm-iguazio tomerm-iguazio commented Feb 22, 2026

This PR update Batch step default to full_event=True.
It also updates all Batch steps tests to operate also with full events throughout.

ML-12099

@tomerm-iguazio tomerm-iguazio marked this pull request as ready for review February 22, 2026 11:16
@tomerm-iguazio tomerm-iguazio requested a review from gtopper March 2, 2026 14:00
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, in line with the decision as cited in https://iguazio.atlassian.net/browse/ML-12099?focusedCommentId=207050.

Please update the PR title to reflect the fact that support isn't removed, but rather deprecated, with the default value changed.

Please make sure this change gets a release note.

Would be good to add a test for the deprecation warning itself, e.g.:

def test_batch_warns_when_full_event_not_specified():
    with pytest.warns(FutureWarning, match="full_event"):
        Batch(4, 100)

While this is a concern we can defer, there are tests in storey and mlrun that would fail once Batch(full_event=False) is actually blocked. See test_to_dataframe_with_index and test_batch_by_user_key in storey, and test_batch in mlrun for examples.

@tomerm-iguazio tomerm-iguazio changed the title [Batch] Remove Support for full_event=false in batch step [Batch] Change batch step default to full_event Mar 3, 2026
@tomerm-iguazio tomerm-iguazio changed the title [Batch] Change batch step default to full_event [Batch] Change batch step default to full event Mar 3, 2026
@gtopper gtopper changed the title [Batch] Change batch step default to full event [Batch] Change batch step default for full_event to True Mar 3, 2026
@gtopper gtopper merged commit aa3901a into mlrun:development Mar 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants