Replace COPY with INSERT ON CONFLICT for dedup support#620
Open
alxtkr77 wants to merge 1 commit intomlrun:developmentfrom
Open
Replace COPY with INSERT ON CONFLICT for dedup support#620alxtkr77 wants to merge 1 commit intomlrun:developmentfrom
alxtkr77 wants to merge 1 commit intomlrun:developmentfrom
Conversation
Replace PostgreSQL COPY protocol with executemany INSERT ... ON CONFLICT DO NOTHING in TimescaleDBTarget. This silently drops duplicate rows when the table has a UNIQUE constraint, preventing duplicate predictions from Kafka rebalance re-delivery. Tables without UNIQUE constraints are unaffected — ON CONFLICT DO NOTHING with no matching constraint behaves as a regular INSERT. - Replace COPY FROM STDIN with executemany INSERT ... ON CONFLICT DO NOTHING - Add integration test proving dedup with UNIQUE constraint - Update docstrings to reflect new write mechanism Fixes: ML-11979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executemany+INSERT ... ON CONFLICT DO NOTHINGinTimescaleDBTargetON CONFLICT DO NOTHINGwith no matching constraint behaves as a regular INSERTChanges Made
storey/timescaledb_target.py: Replacecur.copy(COPY ... FROM STDIN)withcur.executemany(INSERT ... ON CONFLICT DO NOTHING, records)integration/test_timescaledb.py: Addtest_timescaledb_dedup_with_unique_constraint— creates table with UNIQUE(endpoint_id, end_infer_time), emits 3 events + 3 duplicates, verifies only 3 rows storedTesting
Reference