Partition - copyedits#213
Merged
Merged
Conversation
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
…edits
- Survival stacking: introduce via risk sets at unique event times; define
interval-specific indicator; add explicit discrete-time equivalence
(hazard equality + survival/hazard eq cross-refs)
- New figure data-trafo-stacking (drawio) with stacking-only columns, ordering
matching fig 20.2 (drop interval and time-at-risk columns)
- Notation consistency: features-before-time in all dataset tuples, xx_{ij}
throughout the transformed-data context, t_{(j)} for ordered event times
- Regenerate discrete-time/PEM survival-curve figures (theme_bw, line=model,
colour=group conventions)
- Grammar/typo/style fixes; hyphenate attributive "discrete-time" (P1C6)
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
…r effects - Drop the redundant "discrete hazard is the same" (already shown by the equation and the following sentence) and the duplicated smaller-dataset point; tighten the conceptual/computational framing; remove a stale commented note - Cross-reference the flexible time-representation discussion to the foundational chapter's non-linear effects section (label its P3C13 heading)
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did more of a high-level check with this one. It's been reviewed enough times and you're the expert!!
Just two things I wasn't sure about:
Can we really say
\Delta_{ij} \stackrel{iid}{\sim} \text{Bernoulli}(\pi_j), \qquad j = 1, \ldots, J_i,
\Delta_{ij} \mid \xx_{i}, t_j \stackrel{iid}{\sim} \text{Bernoulli}(\pi_{ij}),
etc.
Aren't they based on the original data so not truly independent? Got a bit confused.
In 'representation of time within intervals' you have
This is quite technical quite quickly and in particular starts talking about regularization, penalized splines, etc. etc. And we haven't really talked about the baseline hazard much in the chapter so it kind of through me off a bit. Happy for you to either add one line to explain or just ignore me