Skip to content

Partition - copyedits#213

Merged
RaphaelS1 merged 16 commits into
mainfrom
copyediting_partition
Jun 12, 2026
Merged

Partition - copyedits#213
RaphaelS1 merged 16 commits into
mainfrom
copyediting_partition

Conversation

@RaphaelS1

Copy link
Copy Markdown
Collaborator

Did more of a high-level check with this one. It's been reviewed enough times and you're the expert!!

Just two things I wasn't sure about:

  1. IID

Can we really say

\Delta_{ij} \stackrel{iid}{\sim} \text{Bernoulli}(\pi_j), \qquad j = 1, \ldots, J_i,
\Delta_{ij} \mid \xx_{i}, t_j \stackrel{iid}{\sim} \text{Bernoulli}(\pi_{ij}),

etc.

Aren't they based on the original data so not truly independent? Got a bit confused.

  1. Baseline hazards etc.

In 'representation of time within intervals' you have

  • When $t_j$ is treated as a factor variable, the specific choice of $t_j$ (midpoint, endpoint, etc.) is irrelevant. Each interval receives its own parameter (for example, an interval-specific intercept $\beta_{0j}$), as in the examples in @sec-discrete-time-reduction and @sec-piecewise-constant-hazards. This is the classical PEM approach and provides maximal flexibility, but assumes that the hazard in each interval is estimated independently of neighboring intervals. Without penalization, this can lead to implausible hazard estimates, especially when some intervals contain few events. The number of baseline hazard parameters equals $J$, which becomes prohibitive when $J$ is large (for example, when using all unique event times as cut points).
  • When $t_j$ enters as a continuous variable, the specific choice of $t_j$ is generally of minor importance, except possibly for the final interval and depending on the interval convention. In this setting, a functional relationship between time and the (log-)hazard is assumed. A linear relationship $\log(h_j) = \beta_0 + \beta_1 t_j$ implies that the log-hazard changes at a constant rate over time, which is often too restrictive in practice. Instead, the relationship could be modeled flexibly, for example as $\log(h_j) = f(t_j)$ using penalized splines [@Bender2018Penalized; @Kopper2022] or tree-based methods [@Bender2021]. In this case, the number of baseline hazard parameters depends on the complexity of $f$, not the number of intervals, making the approach scalable to fine partitions. Penalization encourages hazard estimates in neighboring intervals to be similar unless the data provides strong evidence for rapid changes.

This is quite technical quite quickly and in particular starts talking about regularization, penalized splines, etc. etc. And we haven't really talked about the baseline hazard much in the chapter so it kind of through me off a bit. Happy for you to either add one line to explain or just ignore me

RaphaelS1 added 2 commits June 5, 2026 16:58
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
@RaphaelS1
RaphaelS1 requested a review from adibender June 5, 2026 17:20
RaphaelS1 and others added 2 commits June 5, 2026 18:23
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Book 📖

RaphaelS1 and others added 12 commits June 6, 2026 09:19
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
…edits

- Survival stacking: introduce via risk sets at unique event times; define
  interval-specific indicator; add explicit discrete-time equivalence
  (hazard equality + survival/hazard eq cross-refs)
- New figure data-trafo-stacking (drawio) with stacking-only columns, ordering
  matching fig 20.2 (drop interval and time-at-risk columns)
- Notation consistency: features-before-time in all dataset tuples, xx_{ij}
  throughout the transformed-data context, t_{(j)} for ordered event times
- Regenerate discrete-time/PEM survival-curve figures (theme_bw, line=model,
  colour=group conventions)
- Grammar/typo/style fixes; hyphenate attributive "discrete-time" (P1C6)
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
…r effects

- Drop the redundant "discrete hazard is the same" (already shown by the
  equation and the following sentence) and the duplicated smaller-dataset point;
  tighten the conceptual/computational framing; remove a stale commented note
- Cross-reference the flexible time-representation discussion to the foundational
  chapter's non-linear effects section (label its P3C13 heading)
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
@RaphaelS1
RaphaelS1 merged commit 22cb095 into main Jun 12, 2026
1 check passed
@RaphaelS1
RaphaelS1 deleted the copyediting_partition branch June 17, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants