You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mlutze I'm not sure where to introduce a end/win-condition. I think a general GameState -> Bool or GameState -> Option[Winner] where Winner can be tie or somethings like that. I don't know where to introduce this. Is it a part of Gamestate even?
I think it's external to GameState, since the winning condition will eventually depend on the game mode and other configuration. Maybe there's a GameMode namespace?
I think it's external to GameState, since the winning condition will eventually depend on the game mode and other configuration. Maybe there's a GameMode namespace?
I think it's external to GameState, since the winning condition will eventually depend on the game mode and other configuration. Maybe there's a GameMode namespace?
But should the time still be a part of gamestate?
Yes, I agree that time should still be part of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some of #65