Skip to content

feat: add time to Gamestate#104

Draft
JonathanStarup wants to merge 1 commit into
masterfrom
gamestate-time
Draft

feat: add time to Gamestate#104
JonathanStarup wants to merge 1 commit into
masterfrom
gamestate-time

Conversation

@JonathanStarup
Copy link
Copy Markdown
Collaborator

Fixes some of #65

@JonathanStarup
Copy link
Copy Markdown
Collaborator Author

@mlutze I'm not sure where to introduce a end/win-condition. I think a general GameState -> Bool or GameState -> Option[Winner] where Winner can be tie or somethings like that. I don't know where to introduce this. Is it a part of Gamestate even?

@mlutze
Copy link
Copy Markdown
Owner

mlutze commented Oct 20, 2022

I think it's external to GameState, since the winning condition will eventually depend on the game mode and other configuration. Maybe there's a GameMode namespace?

@JonathanStarup
Copy link
Copy Markdown
Collaborator Author

I think it's external to GameState, since the winning condition will eventually depend on the game mode and other configuration. Maybe there's a GameMode namespace?

But should the time still be a part of gamestate?

@mlutze
Copy link
Copy Markdown
Owner

mlutze commented Oct 20, 2022

I think it's external to GameState, since the winning condition will eventually depend on the game mode and other configuration. Maybe there's a GameMode namespace?

But should the time still be a part of gamestate?

Yes, I agree that time should still be part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants