feat: add Set/Map/MutMap without Order#80
Draft
JonathanStarup wants to merge 12 commits into
Draft
Conversation
mlutze
reviewed
Sep 24, 2022
Owner
mlutze
left a comment
mlutze
left a comment
There was a problem hiding this comment.
I am very much in favor of this being a testing ground for all the things we haven't yet convinced Magnus of. :D
| use HashSet.HashSet | ||
|
|
||
| /// invariants: | ||
| /// <<A>> There are no mappings with empty lists |
Owner
There was a problem hiding this comment.
Or maybe laws are public and we need private ones?
Collaborator
Author
There was a problem hiding this comment.
I don't see any law usage in ex. List. How would you use it here (like syntax and everything, I've never used it :P).
Also, isn't laws on Magnus' chopping block?
Owner
There was a problem hiding this comment.
Actually the first one you can take care of by using a Nel instead of a list.
For B you can do something like this I think:
law noDuplicates: forall(h: HashMap[k, v]) . // some boolean expression that says that all the lists have no duplicatesAlternatively you could introduce a ListSet type which itself would have that law.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a bit random, but here it is. Completely untested...
I should copy the std lib tests...