Repository navigation
MC-69: runs are told to add and keep megoocolab.toml up to date - #7
Merged
Merged
Conversation
Agents that create or update megoocolab.toml need its format: the keys of
a set, the name rules, ${NAME} references, the reserved MEGOO_SERVICES_
prefix and that a .env file is never read. The text now lives once in
services.Format, and `megoocolab-runner services --help` shows it, so a
writable run can read it from the command. Later steps put the same text
in a planning run's prompt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…p it up to date (MC-69) PlanSection gives a planning run the text about megoocolab.toml: without the file, it asks for an "Add megoocolab.toml" first step when a check needs a container; with it, it says a step adding a check that needs a new service, port or variable changes the file in that same step. The file's format follows. PromptSection now ends with the same reminder for writable runs. Both share loadOwn and setList. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (MC-69) A new helper, servicesPrompt, picks what a run's prompt gets about megoocolab.toml. A writable run gets the Test services section as before. The first run of a planning session (read-only, role plan, no session to resume) gets the planning section. Drafts, the other read-only roles and a continued planning session get nothing, whether the resume works or falls back to a new session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ab.toml (MC-69) The Test services section of the runner README now says that writable runs are asked to add a service, port or variable that new work needs to the file in the same commit, and that the first run of a planning session is told to add the file as the plan's first step, or to change it in the step that needs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mmhy2003
commented
Nov 18, 2026
mmhy2003
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: approved
The change does what the approved design and plan ask, step by step:
services.Formatis written once.services --helpprints it, andTestFormatNamesEveryKeyfails if a key is added tosetDocwithout being documented inFormat.PlanSectioncovers four cases: no file (the agent is asked for an "Add megoocolab.toml" first step, but only when a check needs a container), a file with sets, a file with no sets (no "Add" text), and an invalid file (logged, and the run gets nothing). Only the worktree's own file counts.servicesPromptsendsPromptSectionto writable runs andPlanSectiononly to the first turn of a read-onlyplanrun (ResumeSessionID == ""). Drafts, other read-only roles and continued sessions, including the resume fallback, get nothing. Tests cover each case.- The writable section now ends with the keep-it-up-to-date sentence, which covers the 18:50 UTC instruction. The README says what each kind of run is told.
I checked that rolePlan = "plan" matches the backend's RunRole.plan. go vet ./... and go test -count=1 ./... pass in runner/ locally, and every CI check is green.
The by-hand planning checks listed in the plan's "Final verification" need a live server and runner, so I did not run them here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
megoocolab-runner services --helpnow prints the format ofmegoocolab.toml(sets,description,compose,ports,env,${NAME}expansion,MEGOO_SERVICES_*variables, and how to run a check throughservices run). A test fails if a new key is added to the loader without being documented there.plan, first turn of the session) get a "Test services" section:megoocolab.toml.Other read-only roles and resumed planning sessions get no section.
megoocolab.toml(and its Compose files) in the same commit. This follows the request on the task that the agent keep the file up to date when new commands or tests need it.runner/README.md"Test services" describes what planning and writable runs are told.docs/superpowers/.Why
Repos that have checks but no
megoocolab.tomlwere left without containers for their tests. Now the planner adds the file as a step, and later runs keep it current.How it was tested
go test -count=1 ./...inrunner/: passesgo vet ./...andgofmt -l .: cleanMEGOO_DOCKER_TESTS=1 go test ./internal/services -run TestRealDocker: passes🤖 Generated with Claude Code