Clark/allow duplicated inputs#1
Open
clark-hive wants to merge 3 commits intomneilly:mneilly/cythonizefrom
Open
Clark/allow duplicated inputs#1clark-hive wants to merge 3 commits intomneilly:mneilly/cythonizefrom
clark-hive wants to merge 3 commits intomneilly:mneilly/cythonizefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if all rows of X are the same the proposal distribution
qbecomes an array of nan's and calling random_state.choice throwsValueError: probabilities contain NaN.Here's a minimal reproducible example:
I ran into this on the third pytest case in the bolt repo.
This was mentioned later on in the thread where you originally made the fix to the bolt repo: dblalock/bolt#4 (comment) and recently raised again: dblalock/bolt#37.
Or would a better way be to check at the top for the matrix only having 1 unique row and returning that row K times?