Skip to content

[#32] Bound the size of repository checkouts for builds - #49

Open
ecleon26 wants to merge 1 commit into
mnemosyne-systems:mainfrom
ecleon26:fix-32-checkout-size
Open

ecleon26 wants to merge 1 commit into
mnemosyne-systems:mainfrom
ecleon26:fix-32-checkout-size

Conversation

@ecleon26

Copy link
Copy Markdown
Collaborator

fixes [#32]

@ecleon26
ecleon26 force-pushed the fix-32-checkout-size branch from 537c28f to bf9733c Compare November 13, 2026 12:08
@ecleon26

Copy link
Copy Markdown
Collaborator Author

@jesperpedersen @sksingh2005 PTAL i have resolved the conflicts

@sksingh2005 sksingh2005 added the bug Something isn't working label Nov 13, 2026
@sksingh2005
sksingh2005 self-requested a review November 13, 2026 20:07

@sksingh2005 sksingh2005 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @ecleon26 . I'd like to see these two gaps addressed before merging:

  1. The size check measures Git blobs before checkout, but the files written to disk can be larger. I reproduced this with *.txt text eol=crlf in .gitattributes: a 1,000,000-byte blob passes the 1 MiB limit, then produces a 1,500,000-byte file. Could we account for checkout expansion and verify the resulting filesystem size?

  2. The limits apply to the initial JGit checkout, but the image then clones the branch again without them. If the branch moves to an oversized commit between those fetches, the second clone can consume the disk space before the revision check rejects it. Could we reuse the validated checkout or enforce the same limits during the second clone?

The first case was reproduced with this PR's checkout code. The second follows from the current clone flow. Both leave gaps in the checkout size protection this change is meant to provide.

@ecleon26
ecleon26 force-pushed the fix-32-checkout-size branch from bf9733c to 134460f Compare November 14, 2026 06:16
@ecleon26

Copy link
Copy Markdown
Collaborator Author

@sksingh2005 i have done all the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants