Repository navigation
Conversation
537c28f to
bf9733c
Compare
|
@jesperpedersen @sksingh2005 PTAL i have resolved the conflicts |
sksingh2005
left a comment
There was a problem hiding this comment.
Thanks for the work @ecleon26 . I'd like to see these two gaps addressed before merging:
-
The size check measures Git blobs before checkout, but the files written to disk can be larger. I reproduced this with
*.txt text eol=crlfin.gitattributes: a 1,000,000-byte blob passes the 1 MiB limit, then produces a 1,500,000-byte file. Could we account for checkout expansion and verify the resulting filesystem size? -
The limits apply to the initial JGit checkout, but the image then clones the branch again without them. If the branch moves to an oversized commit between those fetches, the second clone can consume the disk space before the revision check rejects it. Could we reuse the validated checkout or enforce the same limits during the second clone?
The first case was reproduced with this PR's checkout code. The second follows from the current clone flow. Both leave gaps in the checkout size protection this change is meant to provide.
bf9733c to
134460f
Compare
|
@sksingh2005 i have done all the changes |
fixes [#32]