Skip to content

feat: supabase storage integration - #386

Closed
rajan-personal wants to merge 5 commits into
mnfst:mainfrom
rajan-personal:master
Closed

feat: supabase storage integration#386
rajan-personal wants to merge 5 commits into
mnfst:mainfrom
rajan-personal:master

Conversation

@rajan-personal

@rajan-personal rajan-personal commented Apr 14, 2025

Copy link
Copy Markdown

Description

Supabase s3 integration.

Related Issues

#376

How can it be tested?

in .env

S3_PROVIDER=supabase    # new variable
S3_ENDPOINT=https://xxxxxxxxxx.supabase.co/storage/v1     # Remove /s3

docs

Check list before submitting

  • This PR is wrote in a clear language and correctly labeled
  • I created the related changeset for my changes with npx changeset
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR

@brunobuddy brunobuddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rajan-personal this compatibility seems nice but you should make the tests in order to go ahead

@rajan-personal

Copy link
Copy Markdown
Author

How do I proceed with supabase object upload and download test?

@brunobuddy

Copy link
Copy Markdown
Member

@rajan-personal you can mock it

@rajan-personal

Copy link
Copy Markdown
Author

I am facing multiple issues with current tests when cache is removed. Can you look into its test.

@rajan-personal

Copy link
Copy Markdown
Author

@brunobuddy , I have updated the tests. Do let me know if there are any changes required. I am new to testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants