Fix iOS orientation for upside down orientation#3102
Open
Fishbowler wants to merge 2 commits intomainfrom
Open
Fix iOS orientation for upside down orientation#3102Fishbowler wants to merge 2 commits intomainfrom
Fishbowler wants to merge 2 commits intomainfrom
Conversation
Would crash without this, also with "face down" stuff too, perhaps
Fishbowler
force-pushed
the
ios-orientations
branch
from
f0dee1c to
5b6c7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found whilst adding tests to our demo_app. Would crash without this. Claude reckons it's better this way "face down" stuff too, perhaps.
Proposed changes
Adds support for "portrait upside down" orientation.
Testing
Builds and runs, and no longer crashes when I run
setOrientation. I haven't get got a portrait upside-down test fully working yet though... linkIssues fixed