Skip additional config files in workspace execution planner#3150
Merged
Skip additional config files in workspace execution planner#3150
Conversation
…estro into fix/config_file_checks
proksh
changed the title
Fishbowler
approved these changes
Apr 8, 2026
- Changed topLevelKeys check from `any` to `all` so only files where every top-level key is a WorkspaceConfig property are excluded - Skip files containing `---` document separator since those are flow files, not config files
amanjeetsingh150
approved these changes
Apr 9, 2026
fix:resolve_config_path_before_filtering_flow_files
- Changed topLevelKeys check from `any` to `all` so only files where every top-level key is a WorkspaceConfig property are excluded - Skip files containing `---` document separator since those are flow files, not config files
…estro into fix/config_file_checks
btrautmann
added a commit
to btrautmann/Maestro
that referenced
this pull request
Apr 9, 2026
Upstream added 018_additional_config_files in mobile-dev-inc#3150, conflicting with our 018_negation_with_specific_positive fixture. Renumbered ours to 019. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a workspace, Maestro needs to distinguish between flow files (test scripts) and config files (workspace settings like platform configuration, tag filters, etc.). Previously, config files were only detected by filename - checking for exact match
config.yaml. This meant any config file other than "config" name (e.g. platform_settings.yaml) would be incorrectly treated as a flow file and fail to parse. Maestro docsThis PR replaces the filename-based heuristic with content-based detection. It reads the top-level YAML keys of each file and checks if any match known
WorkspaceConfigproperties (platform, includeTags, excludeTags, flows, etc.). The set of known keys is derived via reflection from the WorkspaceConfig data class, so it automatically stays in sync as new config fields are added - no hardcoded lists to maintain.Test