fix MaestroTimer.withTimeout usage for iOS app stop / start#3164
Open
rubu wants to merge 1 commit intomobile-dev-inc:mainfrom
Open
fix MaestroTimer.withTimeout usage for iOS app stop / start#3164rubu wants to merge 1 commit intomobile-dev-inc:mainfrom
rubu wants to merge 1 commit intomobile-dev-inc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I hit a case where trying to test an app that was linking to a missing framework crashed immediately but the launchApp command in maestro never resolved, while looking into that I noticed that both
ensureStopped/ensureRunninguse a while loop insideMaestroTimer.withTimeoutwhich expects the block to return, but in this case if the app either does not start (or at least is dead until the first check or vice versa never stops) those blocks run indefinitely. This was the fix that helped locally to at least honour the 10s timeout.A complete fix would be to maybe take into account the state of the original spawn process - if that has exited then the app is dead, but that is a much broader change whereas this fix seems intuitive to me and since i'm new to this tool I dont know the policies etc.
Testing
I verified that an app launch for an app that crashes immediately actually fails after 10s instead of hanging.
Issues fixed