chore: clean up unused parameters - #7060
Open
mmorel-35 wants to merge 6 commits into
Open
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
tonistiigi
reviewed
Aug 25, 2026
tonistiigi
left a comment
tonistiigi
left a comment
Member
There was a problem hiding this comment.
I'm not sure this is worth it. These names don't hurt readability and are sometimes actually helpful.
Contributor
Author
|
Would using an "_" prefix together with the appropriate "revive" configuration make this PR more acceptable? That would clearly distinguish intentionally unused parameters while still catching accidental ones. It would also enable linters like "contextcheck", helping avoid propagating "context.Context" where it isn't actually needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable and fixes several linters concerning unused parameters and parameters ordering (context-as-argument rule from revive)