verifier: allow inferred Windows platform versions - #7072
Merged
tonistiigi merged 1 commit intoAug 26, 2026
Conversation
crazy-max
force-pushed
the
fix-platform-verifier-windows-version
branch
from
August 25, 2026 12:26
67bcd8e to
98d0742
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-platform-verifier-windows-version
branch
from
August 25, 2026 13:02
98d0742 to
11c6b9c
Compare
tonistiigi
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to docker/buildx#4008. When testing that change with
docker buildx --builder builder bake https://github.com/docker/buildkit-syft-scanner.git image-all, the verifier reports that the requested platforms includewindows/amd64while the result platforms includewindows(10.0.26100.33296)/amd64:The Dockerfile frontend may infer a concrete Windows OS version from the base image even when the request used versionless
windows/amd64. The verifier already tolerated this for single-platform builds, but multi-platform builds still compared the requested and result platform sets strictly and emitted a mismatch warning.This updates the multi-platform verifier path to use strict platform matching for result platforms that don't match by exact
FormatAllkey. This keeps explicit Windows OS version requests strict, while allowing the existing inferred Windows OS version behavior to pass without warning.