kill process group when container hangs under NoProcessSandbox - #7087
Open
dany74q wants to merge 1 commit into
Open
kill process group when container hangs under NoProcessSandbox#7087dany74q wants to merge 1 commit into
dany74q wants to merge 1 commit into
Conversation
Signed-off-by: Danny Hershko Shemesh <danny@wiz.io>
dany74q
force-pushed
the
kill-process-group-no-process-sandbox
branch
from
August 27, 2026 07:14
839285e to
c92b0ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under --oci-worker-no-process-sandbox,
runc killonly SIGKILLs the in-container init: the container shares the host pid namespace, so subprocesses survive it, and rootless runc cannot enumerate them without cgroups (opencontainers/runc#4398). Survivors keep the container's IO open,runc runnever returns, and the solve never completes. See #4483 and #2855.The fix passes a pidfile to
runc rununder NoProcessSandbox and, when the process has not ended within the existing grace after Kill, SIGKILLs its process group.