Merged
Conversation
Contributor
Author
|
fixed #3573 |
olaservo
approved these changes
Mar 15, 2026
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
All 12 git tool annotations are semantically correct:
Read-only tools (status, diff_unstaged, diff_staged, diff, log, show, branch): All correctly marked readOnlyHint=True, openWorldHint=False. These are pure git query operations with no side effects.
Write tools (add, commit, create_branch, checkout): Correctly marked readOnlyHint=False. Notable details:
git_add:idempotentHint=True— staging the same file twice is a no-op. Correct.git_commit:idempotentHint=False— each call creates a new commit. Correct.git_reset:destructiveHint=True,idempotentHint=True— unstages all changes (destructive), but resetting a clean index is a no-op (idempotent). Correct.
Minor note: the PR body references #3589 (itself) instead of #3573 in the issue field, and is marked as "Bug fix" rather than "New feature". No code impact.
LGTM — thanks @SupunGeethanjana!
Reviewed with the assistance of Claude Code (claude-opus-4-6). Annotation semantics verified against git server implementation and MCP specification.
nielskaspers
pushed a commit
to nielskaspers/servers
that referenced
this pull request
Mar 15, 2026
feat(git): add tool annotations Adds MCP ToolAnnotations to all 12 git server tools, marking read-only operations (status, diff, log, show, branch) and distinguishing destructive (reset) from non-destructive write operations (add, commit, create_branch, checkout). Fixes modelcontextprotocol#3573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Publishing Your Server
Note: We are no longer accepting PRs to add servers to the README. Instead, please publish your server to the MCP Server Registry to make it discoverable to the MCP ecosystem.
To publish your server, follow the quickstart guide. You can browse published servers at https://registry.modelcontextprotocol.io/.
Server Details
Motivation and Context
Issue Number: #3589
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context