fix(filesystem): preserve UNC paths in access validation#3615
Open
BillionClaw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): preserve UNC paths in access validation#3615BillionClaw wants to merge 1 commit intomodelcontextprotocol:mainfrom
BillionClaw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
On Windows, path.resolve() converts UNC paths like \server\share to C:\server\share, corrupting the path and breaking access checks for network shares. Added normalizePathSafe() to detect and preserve UNC paths before normalization, ensuring subdirectories under UNC shares are correctly validated as being within allowed directories. Fixes modelcontextprotocol#3527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
path.resolve()converts UNC paths like \server\share to C:\server\share, corrupting the path and breaking access checks for network shares.The fix adds
normalizePathSafe()to detect and preserve UNC paths before normalization. This ensures subdirectories under UNC shares (like \server\share\folder) are correctly validated as being within allowed directories.Added test coverage for UNC path subdirectory access and prefix attack prevention.
Fixes #3527