feat(ui): add configurable sidebar display - #648
Conversation
|
PR author is not in the allowed authors list. |
|
@skaragianis is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
87a57e3 to
af767d1
Compare
b1ee032 to
7b1b2a4
Compare
Head branch was pushed to by a user without write access
8294f57 to
e07697e
Compare
|
I rebased on |
0ace15d to
cb3e1ef
Compare
|
@benvinegar will you be swinging past again? |
benvinegar
left a comment
There was a problem hiding this comment.
Thanks for the follow-up. The feature looks sound on its original base, and the current head passes typecheck, the targeted tests, and the generated-docs check. Two things need addressing before merge:
- Please rebase onto current
main. #757 changedsto toggle only the active files pane, while this PR'ssidebarStatestill filters every left/right pane througheffectiveOpenPaneKeys. Resolving theApp.tsxconflict mechanically would regress independently opened extension panes. Please apply the configured initial state to the files-pane slot/open state while preserving other extension panes, with coverage for the combined behavior. buildCommonOptionsscans the full rawargv, including pathspecs after--. As a result,hunk diff -- --sidebarandhunk diff -- --no-sidebarboth keep the pathspec and change sidebar state. Please resolve these flags only from command-option tokens before the separator and add a regression test.
This comment was generated by Pi using gpt-5.6-sol
cb3e1ef to
038f973
Compare
benvinegar
left a comment
There was a problem hiding this comment.
Rebased onto current main and addressed both findings. The sidebar preference now controls only the active files-pane slot while preserving independent extension panes, including replacements. Paired boolean flags also stop at the -- separator, with table-driven regression coverage.
This comment was generated by Pi using gpt-5.6-sol
|
Just wanted to say thank you both for this one! 🎉 |
I often turn on the sidebar to keep an eye on agent activity and scope. This makes it a configuration.
Adds
--sidebarand--no-sidebarCLI flags, and asidebarconfiguration with options"auto",true, andfalse. Default remainsauto.truewill not override pager mode or the responsive layout.falsewill override the responsive layout. An 's' keypress continues to toggle where the responsive layout allows.Addresses (#514)