Skip to content

feat(ui): add configurable sidebar display - #648

Merged
benvinegar merged 1 commit into
modem-dev:mainfrom
skaragianis:configurable-sidebar
Aug 16, 2026
Merged

feat(ui): add configurable sidebar display#648
benvinegar merged 1 commit into
modem-dev:mainfrom
skaragianis:configurable-sidebar

Conversation

@skaragianis

@skaragianis skaragianis commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

I often turn on the sidebar to keep an eye on agent activity and scope. This makes it a configuration.

Adds --sidebar and --no-sidebar CLI flags, and a sidebar configuration with options "auto", true, and false. Default remains auto. true will not override pager mode or the responsive layout. false will override the responsive layout. An 's' keypress continues to toggle where the responsive layout allows.

Addresses (#514)

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

@skaragianis is attempting to deploy a commit to the Modem Team on Vercel.

A member of the Team first needs to authorize it.

@skaragianis

Copy link
Copy Markdown
Contributor Author

bun check:docs now passes on 7b1b2a4, if you could approve the pending runs on 8294f57 please.

@benvinegar
benvinegar enabled auto-merge (squash) August 6, 2026 17:23
auto-merge was automatically disabled August 6, 2026 23:55

Head branch was pushed to by a user without write access

@skaragianis
skaragianis force-pushed the configurable-sidebar branch from 8294f57 to e07697e Compare August 6, 2026 23:55
@skaragianis

Copy link
Copy Markdown
Contributor Author

I rebased on main to resolve the conflict with #675 and cleaned up the formatter churn I accidentally left in App.tsx (which is what caused the conflict). No change to the feature itself - the diff is the same minus the whitespace. If you could kick it along again please?

@skaragianis
skaragianis force-pushed the configurable-sidebar branch 6 times, most recently from 0ace15d to cb3e1ef Compare August 11, 2026 22:02
@skaragianis

Copy link
Copy Markdown
Contributor Author

@benvinegar will you be swinging past again?

@benvinegar benvinegar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up. The feature looks sound on its original base, and the current head passes typecheck, the targeted tests, and the generated-docs check. Two things need addressing before merge:

  1. Please rebase onto current main. #757 changed s to toggle only the active files pane, while this PR's sidebarState still filters every left/right pane through effectiveOpenPaneKeys. Resolving the App.tsx conflict mechanically would regress independently opened extension panes. Please apply the configured initial state to the files-pane slot/open state while preserving other extension panes, with coverage for the combined behavior.
  2. buildCommonOptions scans the full raw argv, including pathspecs after --. As a result, hunk diff -- --sidebar and hunk diff -- --no-sidebar both keep the pathspec and change sidebar state. Please resolve these flags only from command-option tokens before the separator and add a regression test.

This comment was generated by Pi using gpt-5.6-sol

@benvinegar
benvinegar force-pushed the configurable-sidebar branch from cb3e1ef to 038f973 Compare August 16, 2026 15:25

@benvinegar benvinegar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto current main and addressed both findings. The sidebar preference now controls only the active files-pane slot while preserving independent extension panes, including replacements. Paired boolean flags also stop at the -- separator, with table-driven regression coverage.

This comment was generated by Pi using gpt-5.6-sol

@benvinegar
benvinegar merged commit c16206f into modem-dev:main Aug 16, 2026
11 of 12 checks passed
@jesseleite

Copy link
Copy Markdown

Just wanted to say thank you both for this one! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants