feat: export static diff renderer - #686
Conversation
|
PR author is not in the allowed authors list. |
|
@privatenumber is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
|
Makes sense! |
benvinegar
left a comment
There was a problem hiding this comment.
Requesting changes for two runtime regressions: the published entry does not run on the package's supported Node versions, and routing pager input through the OpenTUI parser drops loader-owned metadata such as moved-line classification and agent-sidecar ordering.
Validation on a synthetic merge with current main: typecheck, focused tests, package check, lint, formatting, the repository test script, and Node 24 smoke all pass; direct Node 18/20 and colored-patch probes reproduce the issues inline.
This comment was generated by Pi using gpt-5.6-sol
benvinegar
left a comment
There was a problem hiding this comment.
The follow-up fully fixes the two previous findings: packed rendering now works under Node 18/20, and pager output again preserves moved-line metadata and agent-sidecar order. One new terminal-geometry regression remains from the package-wide string-width downgrade.
This comment was generated by Pi using gpt-5.6-sol
|
Addressed in 7b43449. I considered substituting The best balance was one Node 18-compatible width profile shared by both renderers, preserving |
7b43449 to
1268f5f
Compare
|
@benvinegar I rebased onto the latest |
f22cdc9 to
70b54d5
Compare
|
@privatenumber Yep bringing it home |
Head branch was pushed to by a user without write access
Problem
Hunk can render unified patches as terminal-friendly ANSI text for constrained pager hosts, but that renderer is only available inside the CLI. An integration that already has a patch must either start the interactive application or reimplement the presentation layer.
For example, a terminal host can receive
git diffoutput and need a colored stack or split view without taking over input or the alternate screen.Changes
hunkdiff/staticwithrenderStaticDiff(patch, options), returning Hunk's sanitized ANSI output without starting an interactive review.