feat(session): secure daemon upgrades - #929
Closed
benvinegar wants to merge 1 commit into
Closed
Conversation
Contributor
|
Too many files changed for review (68 files, 50 file limit). Bypass the limit by tagging |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hunk session windows and CLI callers need to share one local daemon without trusting public health metadata, PID files, or reusable bearer credentials. Incompatible binaries must not terminate an incumbent daemon that may still own active sessions, while upgraded interactive windows must recover automatically after it becomes quiescent.
Approach
hunk sessioncommands fail-fast with actionable upgrade guidance;Non-goals include forced live handoff, random endpoints/coordinators, service installation, remote-host support, and using generic broker credentials for browser-review routes.
Verification
bun run test— 1,754 passed, 9 skippedbun run test:integration— 137 passed, 1 platform skipbun run test:session-broker-node— 3 passedbun run typecheckbun run lintbun run deps:checkoxfmt --checkandgit diff --checkauthenticated-daemon-upgradescenario and semantic evidence validator passed:tmp/install-vm/runs/2026-08-30T21-38-57-326Z-2065238/result.jsonf723b096c241a9d8844b6ed65db6b146f7067cdaa1a8d1e54c94ddfda723df1af763790815dd1ee32569932962185131329182789d0ccf887d66e8c3cd35606fbf880afa07b7742d165cdafe17e87174175e05be22236db4bf71c2580db2f908/a0671e1ce4495b356da09c242fb75fab04241522dcd3ea794784200060ed2b34No visual evidence is included because this changes daemon/session lifecycle rather than terminal rendering.
Known limitations
This PR description was generated by Pi using gpt-5.6-sol