feat(session): persist review comments across session teardown - #982
Closed
chrismatix wants to merge 1 commit into
Closed
feat(session): persist review comments across session teardown#982chrismatix wants to merge 1 commit into
chrismatix wants to merge 1 commit into
Conversation
Opt-in --persist-comments / persist_comments mirrors the session's review notes to <git-dir>/hunk/review-comments.json on every note change, so an agent can still read them after the TUI dies — including SIGKILL from a closed terminal pane. The file reuses the exact reviewNotes projection that `hunk session review --include-notes --json` publishes and is export-only; sessions never read it back. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018HuW46iwJXWtwXfuUyQDuu
Contributor
|
PR author is not in the allowed authors list. |
|
@chrismatix is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As noted in #113 when closing hunk (eg because you run it in a herdr popup) all your comment state is completely lost which can be very frustrating when working on them with agents.
Implementation
Stores and bootstraps comments from
.git/hunk/review-comments.json.This way comment lifecycle is automatically tied to the git worktree which works nicely with agentic development.
Why not an extension?
Mechanically this could be an extension, but: