Themes: Accept a dark/light theme table - #985
Open
masonmcelvain wants to merge 4 commits into
Open
Conversation
`theme = "auto"` only ever chose between github-light-default and github-dark-default, so a reader who wanted one-light and one-dark-pro had no way to follow their terminal. Accept a `[theme]` table naming both sides instead, with an optional `fallback` for terminals that never answer the background probe, following Helix's config shape. The committed preference now stays whatever config asked for until someone picks a theme in the selector, so quitting without touching themes no longer rewrites `auto` — or a pair — into the one id it happened to resolve to. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Y3vNR6iJEH4epjQo8JARe
The theme writer only recognized the `theme = ` and `[theme]` spellings, while the reader takes whatever Bun.TOML.parse produced. A config written as `theme.dark = "nord"` read fine, then gained a second `theme = "..."` assignment on the next preference save, after which Hunk refused to start with `BuildMessage: Cannot redefine key 'theme'` — an error naming neither the file nor the key. A quoted key inside `[theme]` failed the same way. Match every spelling TOML accepts for a key, and drop the extra lines a dotted key spreads a value over. Saves also deleted comments. The `[theme]` range ran to the next section header, so collapsing the table took the blank lines and comments that introduce whatever follows, and every rewritten key lost its trailing comment. Since one save rewrites all nine preferences, toggling `wrap_lines` stripped comments out of an untouched `[theme]` table. Comments now stay attached to the key or section they introduce, which is also why a collapsed table is written over its own header rather than appended — but only while `[theme]` is the first table, since a top-level key at any later position would scope into the table above it. Theme errors named `theme` whichever section or file held the bad table. That matters more now that a checked-in `.hunk/config.toml` can hard-fail startup for everyone in the repo, so they name both. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BLvy5LioGNhwJHzDPb7xxy
Saving view preferences could leave a config file slightly messier than it found it. Collapsing a [theme] table that sat between two other tables left the blank line from each side, and a file with no tables at all had new keys inserted above its trailing comment, because the backtrack that keeps a comment attached to the table it documents could not tell a real table index from the clamp used when no table exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NJVQRku6dLXkxiACCy177U
An in-session refresh rebuilt its reload input from the theme id the selection currently resolved to, so an adaptive pair arrived at the reload as whichever side the terminal happened to be on. Nothing collapses today because every refresh path keeps the mounted App, but the descriptor is the wrong thing to freeze. Carry the committed selection instead, and leave the resolved id to extension events, which want a concrete theme. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NJVQRku6dLXkxiACCy177U
Contributor
|
PR author is not in the allowed authors list. |
|
@masonmcelvain is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support a
[theme]table inconfig.tomlto set dark/light themes:fallbackcovers sessions where terminal background is unknown, defaulting todark.Writing the pair back exposed that the config writer was rewriting more of
config.tomlthan it should, so that is fixed here too.Changes
Theme selection
src/core/theme/selection.ts: aThemeSelectionis either a theme id or a{ dark, light, fallback? }pair, and the module owns reading, comparing, and resolving one against a terminal background.autodoes.--theme <id>overrides a configured pair for one run.theme_changedevents keep receiving a concrete id.Config writing
themein place instead of appending a second definition, including quoted ("theme" = …) and dotted (theme.dark = …) key forms, and drop duplicate definitions rather than leaving them behind.[theme]table; keep a comment attached to the table it documents.[theme]table to a top-leveltheme = "…"when a single id replaces the pair, leaving one blank line between the neighbours it separated.[theme]section.QA
Themes used below are interchangeable; any two built-in ids work.
[theme]table in~/.config/hunk/config.tomlwith distinguishabledark/lightids, then runhunk diffin a dark terminal and again in a light one. Each should draw its own side.fallbackand run through a host that does not answer the background query (ascript-allocated pty, or LazyGit as a pager). The fallback theme should render; removefallbackanddarkshould.hunk diff --theme github-dark-defaultwith the table still in config should ignore the pair.t, choose a theme, thenq. The prompt should show- theme = { dark = "…", light = "…" }/+ theme = "…", and saving should leave a top-leveltheme = "…"with no[theme]table.[custom_theme]table, and an[extensions]table around the[theme]table. After saving, they should be untouched, with no doubled blank lines, and the file should still parse.r, thent. One side of the pair should still be active, and quitting should not offer to save a theme change.light, or with a typo'd key, should exit 1 naming the file and the problem.