feat(ui): make history automatically responsive - #987
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Sep 5, 2026
benvinegar
marked this pull request as ready for review
September 5, 2026 22:41
Contributor
Greptile SummaryThis PR makes
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified. The CLI-selection contract, responsive projection, navigation semantics, and mouse interactions are internally consistent and covered by focused unit and PTY integration tests. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[hunk log invocation] --> B{--static?}
B -->|Yes| E[Static history output]
B -->|No| C{stdin and stdout are TTYs?}
C -->|No| E
C -->|Yes| D[Interactive history browser]
D --> F{Terminal width}
F -->|96+ columns| G[Wide rows]
F -->|60–95 columns| H[Medium rows]
F -->|Below 60 columns| I[Narrow rows]
D --> J[Open selected commit]
J --> K[Hunk review]
K --> D
Reviews (1): Last reviewed commit: "style(ui): space history entries" | Re-trigger Greptile |
benvinegar
force-pushed
the
feat/hunk-log-responsive
branch
2 times, most recently
from
September 5, 2026 23:07
4ba8d39 to
616912e
Compare
benvinegar
force-pushed
the
feat/hunk-log-responsive
branch
from
September 6, 2026 01:00
616912e to
a4fc330
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Problem
The history stack still exposed static and interactive modes as separate user experiences, and its interactive rows used a conventional left-to-right terminal-log layout. Users should be able to type
hunk logonce and get the right experience for their environment, with information density that responds automatically to available space.Approach
hunk logopen the interactive desktop history browser when stdin and stdout are terminals--staticto force static output on a terminal, paging only when needed--interactiveparsing as a compatibility alias without documenting a second workflowStatic
--onelineand--formatremain available because they control shell output rather than creating competing interactive applications.Validation
bun run typecheckbun run lintbun run check:docsbun run deps:checkgit diff --checkTested on Linux with Git, tmux, and a real TTY. Windows was not tested directly.
Visual evidence
The approved responsive design is available at https://sideshow.sh/p/eAsZCIw7mf4. Real-terminal media can be added while this PR remains draft.
Non-goals
This PR description was generated by Pi using GPT-5.6-sol