Skip to content

refactor(extensions): centralize session ownership - #999

Merged
benvinegar merged 1 commit into
refactor/hunk-session-runtimefrom
refactor/hunk-extension-session
Sep 6, 2026
Merged

refactor(extensions): centralize session ownership#999
benvinegar merged 1 commit into
refactor/hunk-session-runtimefrom
refactor/hunk-extension-session

Conversation

@benvinegar

@benvinegar benvinegar commented Sep 6, 2026

Copy link
Copy Markdown
Member

Summary

  • add a renderer-independent ExtensionSession as the sole owner of active, provisional, adopted, retiring, and closing extension registries
  • preserve extension startup and reload events behind AppHost's matching React layout commit
  • make standalone review, interactive history, static history, and embedded reviews use explicit session ownership
  • require embedded history reviews to borrow the current registry and reject independently owned nested authority
  • preserve provider cursor → extension shutdown → renderer teardown ordering across success and failure paths
  • add lifecycle-aware AppHost helpers for tests and benchmarks

Validation

  • 2,008 unit tests passed; 9 skipped
  • 150 PTY integration tests passed; 1 platform skip
  • 9 TTY smoke tests passed
  • bun run typecheck
  • bun run lint
  • bun run deps:check
  • bun test scripts/source-boundaries.test.ts
  • bun run check:docs
  • git diff --check
  • independent lifecycle and architecture review found no blockers

Stack

  1. refactor(ui): route surfaces through one session runtime #998 — shared session runtime and surface router
  2. refactor(extensions): centralize session ownership #999 — centralized extension session ownership

This PR description was generated by Pi using gpt-5.6-sol

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
hunk-web Ignored Ignored Preview Sep 6, 2026 1:03pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (58 files, 50 file limit).

Bypass the limit by tagging @greptile-apps to review.

@benvinegar
benvinegar force-pushed the refactor/hunk-extension-session branch 2 times, most recently from 4deaad1 to 4856a84 Compare September 6, 2026 12:52
@benvinegar
benvinegar force-pushed the refactor/hunk-extension-session branch from 4856a84 to 733d973 Compare September 6, 2026 12:53
@benvinegar
benvinegar force-pushed the refactor/hunk-extension-session branch from 733d973 to 9af12a5 Compare September 6, 2026 13:02
@benvinegar
benvinegar merged commit 61f9a1a into main Sep 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant