Install WP-CLI before composer install#365
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
We currently install WP-CLI via composer so that it's available for the WordPress installer which runs as a post-install-cmd. However, the composer-installed WP-CLI bundle has ourdated dependencies; and, it overrides any host-installed versions of WP-CLI.
On our Dokku server, there's no way to inject the WP-CLI install after PHP is installed, but before composer is run as the Heroku PHP buildpack does both actions together.
Thus, I've moved the Wp-CLI install to the top of the wordpress-install script. It is conditionally run only in Dokku envs and only if WP-CLI isn't installed already.
Additionally, I've cleaned up the action versions a bit to remove any node 20 deprecation notices during deployments.
Finally, I've locked the required version of PHP to stay with 8.4.
Pull request checklist