-
Notifications
You must be signed in to change notification settings - Fork 0
v2.2.4 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.2.4 #10
Changes from all commits
0840930
f048189
f0fbc71
f767958
606328e
2e0b7cb
42abba0
2963dab
a20f0c4
6144e57
7e1e1e8
540c0cb
3c823c0
4939eb7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| # Development environment configuration | ||
| # This file is used when running: npm run dev | ||
|
|
||
| # API URL - empty to use vite proxy to localhost:8080 | ||
| VITE_API_BASE_URL= | ||
|
|
||
| # App domain for local testing | ||
| APP_DOMAIN=localhost | ||
|
|
||
| # Turnstile test keys (Cloudflare provides test keys for development) | ||
| VITE_TURNSTILE_SITE_KEY=1x00000000000000000000AA | ||
|
|
||
| # Docs URL | ||
| VITE_DOCS_URL=https://docs.modl.top | ||
| # Development environment configuration | ||
| # This file is used when running: npm run dev | ||
| # API URL - empty to use vite proxy to localhost:8080 | ||
| VITE_API_BASE_URL= | ||
| # App domain for local testing | ||
| APP_DOMAIN=localhost | ||
| # Turnstile test keys (Cloudflare provides test keys for development) | ||
| VITE_TURNSTILE_SITE_KEY=1x00000000000000000000AA | ||
| # Docs URL | ||
| VITE_DOCS_URL=https://docs.modl.gg |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| # Production environment configuration | ||
| # This file is used when running: npm run build | ||
|
|
||
| # API URL - points to production API | ||
| VITE_API_BASE_URL=https://api.modl.gg | ||
|
|
||
| # App domain | ||
| APP_DOMAIN=modl.gg | ||
|
|
||
| # Docs URL | ||
| VITE_DOCS_URL=https://docs.modl.gg | ||
| # Production environment configuration | ||
| # This file is used when running: npm run build | ||
| # API URL - points to production API | ||
| VITE_API_BASE_URL=https://api.modl.gg | ||
| # App domain | ||
| APP_DOMAIN=modl.gg | ||
| # Docs URL | ||
| VITE_DOCS_URL=https://docs.modl.gg |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,44 @@ | ||
| name: "Build (Pull Request)" | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| branches: | ||
| - main | ||
| - dev | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| contents: read | ||
| packages: read | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '23' | ||
| registry-url: 'https://npm.pkg.github.com' | ||
| scope: '@modl-gg' | ||
|
|
||
| - name: Configure npm for GitHub Packages | ||
| run: | | ||
| rm .npmrc | ||
| echo "@modl-gg:registry=https://npm.pkg.github.com" >> .npmrc | ||
| echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> .npmrc | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Run build | ||
| run: npm run build | ||
| name: "Build (Pull Request)" | ||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| branches: | ||
| - main | ||
| - dev | ||
| workflow_dispatch: | ||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: read | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '23' | ||
| registry-url: 'https://npm.pkg.github.com' | ||
| scope: '@modl-gg' | ||
| - name: Configure npm for GitHub Packages | ||
| run: | | ||
| rm .npmrc | ||
| echo "@modl-gg:registry=https://npm.pkg.github.com" >> .npmrc | ||
| echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> .npmrc | ||
|
Comment on lines
+28
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The committed Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/build.yml
Line: 28-34
Comment:
**Registry config overwritten**
The committed `.npmrc` now points `@modl-gg` packages at the Nexus registry, but this workflow still deletes that file and rewrites it to GitHub Packages before `npm ci`. CI no longer tests the package registry configuration that developers and deployments get from the repository, and installs can fail or diverge if `@modl-gg/shared-web` is expected to come from Nexus.
How can I resolve this? If you propose a fix, please make it concise. |
||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Install dependencies | ||
| run: npm ci | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Run build | ||
| run: npm run build | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.npmrcnow points@modl-ggpackages at the Nexus registry, and the lockfile resolves@modl-gg/shared-webfrom Nexus. This workflow deletes that config and rewrites the scope back to GitHub Packages beforenpm ci, so CI can resolve the private package from the wrong registry whenever the lockfile is refreshed or the package is no longer mirrored there.Prompt To Fix With AI