Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .env.development
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Development environment configuration
# This file is used when running: npm run dev

# API URL - empty to use vite proxy to localhost:8080
VITE_API_BASE_URL=

# App domain for local testing
APP_DOMAIN=localhost

# Turnstile test keys (Cloudflare provides test keys for development)
VITE_TURNSTILE_SITE_KEY=1x00000000000000000000AA

# Docs URL
VITE_DOCS_URL=https://docs.modl.top
# Development environment configuration
# This file is used when running: npm run dev
# API URL - empty to use vite proxy to localhost:8080
VITE_API_BASE_URL=
# App domain for local testing
APP_DOMAIN=localhost
# Turnstile test keys (Cloudflare provides test keys for development)
VITE_TURNSTILE_SITE_KEY=1x00000000000000000000AA
# Docs URL
VITE_DOCS_URL=https://docs.modl.gg
22 changes: 11 additions & 11 deletions .env.production
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Production environment configuration
# This file is used when running: npm run build

# API URL - points to production API
VITE_API_BASE_URL=https://api.modl.gg

# App domain
APP_DOMAIN=modl.gg

# Docs URL
VITE_DOCS_URL=https://docs.modl.gg
# Production environment configuration
# This file is used when running: npm run build
# API URL - points to production API
VITE_API_BASE_URL=https://api.modl.gg
# App domain
APP_DOMAIN=modl.gg
# Docs URL
VITE_DOCS_URL=https://docs.modl.gg
88 changes: 44 additions & 44 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,44 +1,44 @@
name: "Build (Pull Request)"

on:
pull_request:
types: [opened, synchronize, reopened]
branches:
- main
- dev
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest

permissions:
contents: read
packages: read

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '23'
registry-url: 'https://npm.pkg.github.com'
scope: '@modl-gg'

- name: Configure npm for GitHub Packages
run: |
rm .npmrc
echo "@modl-gg:registry=https://npm.pkg.github.com" >> .npmrc
echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> .npmrc
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Install dependencies
run: npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Run build
run: npm run build
name: "Build (Pull Request)"
on:
pull_request:
types: [opened, synchronize, reopened]
branches:
- main
- dev
workflow_dispatch:
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
packages: read
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '23'
registry-url: 'https://npm.pkg.github.com'
scope: '@modl-gg'
- name: Configure npm for GitHub Packages
run: |
rm .npmrc
echo "@modl-gg:registry=https://npm.pkg.github.com" >> .npmrc
echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> .npmrc
Comment on lines +30 to +34

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Registry override mismatch The repository .npmrc now points @modl-gg packages at the Nexus registry, and the lockfile resolves @modl-gg/shared-web from Nexus. This workflow deletes that config and rewrites the scope back to GitHub Packages before npm ci, so CI can resolve the private package from the wrong registry whenever the lockfile is refreshed or the package is no longer mirrored there.

Suggested change
- name: Configure npm for GitHub Packages
run: |
rm .npmrc
echo "@modl-gg:registry=https://npm.pkg.github.com" >> .npmrc
echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> .npmrc
- name: Configure npm for Nexus
run: |
rm .npmrc
echo "@modl-gg:registry=https://nexus.modl.gg/repository/npm-releases/" >> .npmrc
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/build.yml
Line: 30-34

Comment:
**Registry override mismatch** The repository `.npmrc` now points `@modl-gg` packages at the Nexus registry, and the lockfile resolves `@modl-gg/shared-web` from Nexus. This workflow deletes that config and rewrites the scope back to GitHub Packages before `npm ci`, so CI can resolve the private package from the wrong registry whenever the lockfile is refreshed or the package is no longer mirrored there.

```suggestion
    - name: Configure npm for Nexus
      run: |
        rm .npmrc
        echo "@modl-gg:registry=https://nexus.modl.gg/repository/npm-releases/" >> .npmrc
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

Comment on lines +28 to +34

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Registry config overwritten

The committed .npmrc now points @modl-gg packages at the Nexus registry, but this workflow still deletes that file and rewrites it to GitHub Packages before npm ci. CI no longer tests the package registry configuration that developers and deployments get from the repository, and installs can fail or diverge if @modl-gg/shared-web is expected to come from Nexus.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/build.yml
Line: 28-34

Comment:
**Registry config overwritten**

The committed `.npmrc` now points `@modl-gg` packages at the Nexus registry, but this workflow still deletes that file and rewrites it to GitHub Packages before `npm ci`. CI no longer tests the package registry configuration that developers and deployments get from the repository, and installs can fail or diverge if `@modl-gg/shared-web` is expected to come from Nexus.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Install dependencies
run: npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Run build
run: npm run build
Loading
Loading