v2.3.1 #105
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,24 +56,40 @@ const DomainSettings: React.FC = () => { | |
| const loadDomainConfig = async () => { | ||
| try { | ||
| const response = await apiFetch('/v1/panel/settings/domain'); | ||
| if (!response.ok) { | ||
| toast({ | ||
| title: t('toast.error'), | ||
| description: t('settings.domain.loadFailed'), | ||
| variant: "destructive", | ||
| }); | ||
| return; | ||
| } | ||
| const data = await response.json(); | ||
| if (data.customDomain) { | ||
| setCustomDomain(data.customDomain); | ||
| setDomainStatus(data.status); | ||
| } | ||
| setAccessingFromCustomDomain(data.accessingFromCustomDomain || false); | ||
| setModlSubdomainUrl(data.modlSubdomainUrl || ''); | ||
| setCanManageCustomDomain(Boolean(data.canManageCustomDomain)); | ||
| } catch (error) { | ||
| toast({ | ||
| title: t('toast.error'), | ||
| description: t('settings.domain.loadFailed'), | ||
| variant: "destructive", | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| const validateDomain = (domain: string): boolean => { | ||
| const normalized = domain.trim(); | ||
| if (normalized.length === 0 || normalized.length > 253) { | ||
| return false; | ||
| } | ||
| if (!normalized.includes('.')) { | ||
| return false; | ||
| } | ||
| return !/\s/.test(normalized); | ||
| }; | ||
|
Comment on lines
84
to
93
There was a problem hiding this comment.
The new validation accepts any dotted, whitespace-free string, including invalid hostnames such as Rule Used: This is a React frontend project on React 19 with ... (source) Prompt To Fix With AIThis is a comment left during a code review.
Path: client/src/components/settings/DomainSettings.tsx
Line: 84-93
Comment:
**Domain validation accepts malformed hosts**
The new validation accepts any dotted, whitespace-free string, including invalid hostnames such as `a..b`, `a_.example.com`, and `-panel.example.com`, so these values produce unnecessary configuration requests and defer basic validation to the API or DNS provider.
**Rule Used:** This is a React frontend project on React 19 with ... ([source](https://app.greptile.com/modl-gg/-/custom-context?memory=b7532101-0c9e-4ab6-b168-353a105ba593))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||
|
|
||
| const handleDomainSubmit = async () => { | ||
|
|
@@ -104,15 +120,6 @@ const DomainSettings: React.FC = () => { | |
| return; | ||
| } | ||
|
|
||
| setIsLoading(true); | ||
| try { | ||
| const response = await apiFetch('/v1/panel/settings/domain', { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user selects the new pretty-date option, profile autosave submits
MMM D, YYYY, but the backend allowlist accepts only the three legacy formats, so the displayed selection is not persisted and reverts after the profile is refreshed.Context Used: Ensure all code meets SOLID, DRY, and KISS softwar... (source)
Artifacts
Repro: executable focused client-to-backend persistence contract harness
Repro: before-change legacy selection PATCH and profile reload responses
Repro: after-change pretty selection PATCH and reverted profile reload responses
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!