Skip to content

For Apple silicon, add separation between architecture and Metal API selection #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ahajha merged 1 commit into from
Jun 25, 2026
Merged

For Apple silicon, add separation between architecture and Metal API selection #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions mojo/extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,16 @@ _gpu_toolchains_tag = tag_class(
"mi325": "amdgpu:gfx942",
"mi355": "amdgpu:gfx950",
"rtx5090": "nvidia:120a",
"metal3": "metal:30",
"metal4": "metal:40",
"metal1": "metal:1",
"metal2": "metal:2",
"metal3": "metal:3",
"metal4": "metal:4",
"metal5": "metal:5",
"metal1_metal4": "metal:1-metal4",
"metal2_metal4": "metal:2-metal4",
"metal3_metal4": "metal:3-metal4",
"metal4_metal4": "metal:4-metal4",
"metal5_metal4": "metal:5-metal4",
},
doc = "The GPUs supported by this toolchain, mapping to Mojo's target accelerators.",
),
Expand All @@ -227,8 +235,11 @@ _gpu_toolchains_tag = tag_class(
"MI355": "mi355",
"Navi": "radeon",
"AMD Radeon Graphics": "radeon",
"Metal 3": "metal3",
"Metal 4": "metal4",
"Apple M1": "metal1",
"Apple M2": "metal2",
"Apple M3": "metal3",
"Apple M4": "metal4",
"Apple M5": "metal5",
},
doc = "The output from nvidia-smi or rocm-smi to the corresponding GPU name in SUPPORTED_GPUS.",
),
Expand Down
33 changes: 24 additions & 9 deletions mojo/mojo_host_platform.bzl
View file
Open in desktop
Comment thread
Ahajha marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ def _get_amd_constraints_with_rocm_smi(rctx, rocm_smi, gpu_mapping):

return constraints

def _toolchain_supports_metal4(rctx):
result = rctx.execute(["/usr/bin/xcrun", "--sdk", "macosx", "--show-sdk-version"])
_log_result(rctx, "/usr/bin/xcrun --sdk macosx --show-sdk-version", result)
if result.return_code != 0:
return False
return int(result.stdout.strip().split(".")[0]) >= 26

def _get_apple_constraint(rctx, gpu_mapping):
result = rctx.execute(["/usr/bin/sw_vers", "--productVersion"])
_log_result(rctx, "/usr/sbin/sw_vers --productVersion", result)
Expand All @@ -102,21 +109,29 @@ def _get_apple_constraint(rctx, gpu_mapping):

_log_result(rctx, "/usr/sbin/system_profiler SPDisplaysDataType", result)

metal_version = None
chipset_model = None
metal_support = None
for line in result.stdout.splitlines():
if "Metal Support:" in line:
metal_version = line
break
if "Chipset Model:" in line:
chipset_model = line
elif "Metal Support:" in line:
metal_support = line

if not metal_version: # macOS VMs may not have GPUs attached
if not chipset_model: # macOS VMs may not have GPUs attached
return None

metal4 = (
metal_support and "Metal 4" in metal_support and
_toolchain_supports_metal4(rctx)
)

for gpu_name, constraint in gpu_mapping.items():
if gpu_name in metal_version:
if constraint:
return "@mojo_gpu_toolchains//:{}_gpu".format(constraint)
else:
if gpu_name in chipset_model:
if not constraint:
return None
if metal4:
constraint += "_metal4"
return "@mojo_gpu_toolchains//:{}_gpu".format(constraint)

_fail(rctx, "Unrecognized system_profiler output, please add it to your gpu_mapping in the MODULE.bazel file: {}".format(result.stdout))
return None
Expand Down
Loading