Skip to content

MOEN-41290: Added Swift Package Manager distribution support#91

Merged
msoumya-engg-sdk merged 1 commit intodevelopmentfrom
MOEN-41290_spm
Nov 6, 2025
Merged

MOEN-41290: Added Swift Package Manager distribution support#91
msoumya-engg-sdk merged 1 commit intodevelopmentfrom
MOEN-41290_spm

Conversation

@msoumya-engg-sdk
Copy link
Copy Markdown
Contributor

Jira Ticket

Description

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Swift Package Manager (SPM) distribution support to the iOS-PluginBase library, transitioning from a CocoaPods-only distribution to support both CocoaPods and SPM.

Key Changes:

  • Added Swift Package Manager manifest (Package.swift) with automated generation
  • Restructured project to support both CocoaPods and SPM distribution methods
  • Consolidated package management by removing separate plugin packages and moving them to dedicated repositories

Reviewed Changes

Copilot reviewed 69 out of 135 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
Package.swift New SPM manifest defining package structure and dependencies
Utilities/post_build.rb Script to auto-generate Package.swift from package.json configuration
Utilities/release_dependents.rb Script to trigger dependent repository releases
package.json Updated to single package configuration with postBuild script
MoEngagePluginBase.podspec Inline podspec configuration replacing shared spec utility
Rakefile Build automation for project setup using Tuist
Examples/* New example project structure using Tuist for project generation
CONTRIBUTING.md Developer setup and contribution guidelines
.github/workflows/ci.yml CI pipeline for both CocoaPods and SPM validation
.github/workflows/cd.yml Enhanced CD workflow with dependent release triggers
Files not reviewed (2)
  • Example/MoEPluginBaseExample.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
  • Example/MoEPluginBaseExample.xcworkspace/contents.xcworkspacedata: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@msoumya-engg-sdk msoumya-engg-sdk force-pushed the MOEN-41290_spm branch 3 times, most recently from 7528f34 to a9a554b Compare October 27, 2025 06:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 69 out of 135 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • Example/MoEPluginBaseExample.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
  • Example/MoEPluginBaseExample.xcworkspace/contents.xcworkspacedata: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@msoumya-engg-sdk msoumya-engg-sdk force-pushed the MOEN-41290_spm branch 2 times, most recently from e139e6e to b9d1c7f Compare October 27, 2025 07:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 69 out of 135 changed files in this pull request and generated 3 comments.

Files not reviewed (2)
  • Example/MoEPluginBaseExample.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
  • Example/MoEPluginBaseExample.xcworkspace/contents.xcworkspacedata: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

],
dependencies: [
// Dependencies declare other packages that this package depends on.
.package(url: "https://github.com/moengage/apple-sdk.git", exact: "#{config.sdkVerMin}")
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using exact version constraints in SPM dependencies can prevent automatic bug fixes and security updates. Consider using upToNextMinor or upToNextMajor version requirements instead, or document why exact versioning is required for this dependency.

Suggested change
.package(url: "https://github.com/moengage/apple-sdk.git", exact: "#{config.sdkVerMin}")
.package(url: "https://github.com/moengage/apple-sdk.git", from: "#{config.sdkVerMin}")

Copilot uses AI. Check for mistakes.
@msoumya-engg-sdk msoumya-engg-sdk merged commit d2be148 into development Nov 6, 2025
6 checks passed
@msoumya-engg-sdk msoumya-engg-sdk deleted the MOEN-41290_spm branch November 6, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants